cli-lab icon indicating copy to clipboard operation
cli-lab copied to clipboard

[main] Update dependencies from dotnet/arcade

Open dotnet-maestro[bot] opened this issue 7 months ago • 2 comments

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

  • Updates to .NET SDKs:
    • Updates tools.dotnet to 10.0.100-preview.6.25302.104

dotnet-maestro[bot] avatar Jun 09 '25 05:06 dotnet-maestro[bot]

PR is currently failing with:

.packages/microsoft.dotnet.arcade.sdk/10.0.0-beta.25305.3/tools/Publish.proj(429,5): error : (NETCORE_ENGINEERING_TELEMETRY=Publish) ItemsToPush is not specified.

See https://github.com/dotnet/arcade/issues/15871#issuecomment-2949460851.

Youssef1313 avatar Jun 11 '25 16:06 Youssef1313

@edvilme Could you look please?

Youssef1313 avatar Jun 14 '25 04:06 Youssef1313

@marcpopMSFT Can you help who should look at this please? This is a blocker for me PR for xunit.v3+MTP: https://github.com/dotnet/cli-lab/pull/385

Youssef1313 avatar Jul 18 '25 04:07 Youssef1313

Ping @marcpopMSFT @edvilme to help unblocking this please.

Youssef1313 avatar Jul 27 '25 16:07 Youssef1313

@Youssef1313 @dotnet/dnceng this appears to be caused by a change in Arcade. The cli-lab repo uses cibuild.cmd which automatically adds -publish but we don't produce any nupkgs. It appears that this ends up calling PushToBuildStorage with an empty ItemsToPush. From what I can tell from older builds though is that it always did this and it's only with this arcade update that that is failing.

There's no condition on PublishToAzureDevOpsArtifacts so I can't skip the target that contains that task. Let me know if there's some other way I can skip the publish as an alternative.

@mmitche looks like you added that error about 3 months ago: https://github.com/dotnet/arcade/commit/5db7250a490dbdf100f5d05f47e29ab234c170a5

marcpopMSFT avatar Aug 01 '25 17:08 marcpopMSFT

@marcpopMSFT Instead of calling eng/common/cibuild.cmd, couldn't you call the build.cmd in repo root and duplicate the arguments from cibuild.cmd (except publish)? (https://github.com/dotnet/arcade/issues/15871#issuecomment-2949460851)

Youssef1313 avatar Aug 01 '25 18:08 Youssef1313

@marcpopMSFT See also https://teams.microsoft.com/l/message/19:[email protected]/1747693551187?tenantId=72f988bf-86f1-41af-91ab-2d7cd011db47&groupId=4d73664c-9f2f-450d-82a5-c2f02756606d&parentMessageId=1747382564685&teamName=.NET%20Core%20Eng%20Services%20Partners&channelName=First%20Responders&createdTime=1747693551187

Youssef1313 avatar Aug 01 '25 18:08 Youssef1313

@marcpopMSFT See also Following the chat guidance, I switched to using build.cmd instead of cibuild, I copied all of the CLI arguments in but excluded publish. Let's see if that solves this.

marcpopMSFT avatar Aug 01 '25 18:08 marcpopMSFT