cli-lab icon indicating copy to clipboard operation
cli-lab copied to clipboard

[NETSDKE2E][MAC]The text "Used by VS for Mac..." next to net 9 SDK needs to be updated as VS Mac has been end of life.

Open vdanche opened this issue 1 year ago • 1 comments

To Reproduce 1.Prepare a clean Intel 2.install dotnet-core-uninstall(1.7.550802) 3. Use the following commands to install the tool:

mkdir -p ~/dotnet-core-uninstall
tar -zxvf dotnet-core-uninstall.tar.gz -C ~/dotnet-core-uninstall
cd ~/dotnet-core-uninstall
./dotnet-core-uninstall list

4.Install 9.0.rc2 sdk and some others sdk . e.g 8.0.403 sdk... 5. Run "./dotnet-core-uninstall list" 6.check the output of dotnet-core-uninstall list

Expected Result: The output of dotnet-core-uninstall list display well.

Actual Result: The text "Used by VS for Mac..." next to net 9 SDK needs to be updated as VS Mac has been end of life. Image

dotnet --info: Image

vdanche avatar Oct 18 '24 02:10 vdanche

I kind of think we should just remove this check entirely. @baronfel @joeloff https://github.com/dotnet/cli-lab/blob/25e91f1d39ad446131c0fe4bc998c5a33e766773/src/dotnet-core-uninstall/Shared/VSVersioning/VisualStudioSafeVersionsExtractor.cs#L53

not a blocker.

marcpopMSFT avatar Oct 18 '24 17:10 marcpopMSFT

I kind of think we should just remove this check entirely. @baronfel @joeloff

cli-lab/src/dotnet-core-uninstall/Shared/VSVersioning/VisualStudioSafeVersionsExtractor.cs

Line 53 in 25e91f1

private static (IDictionary<IEnumerable<Bundle>, string>, IEnumerable<Bundle>) ApplyMacVersionDivisions(IEnumerable<Bundle> bundleList) not a blocker.

Do you mean for all versions? Including versions prior to .net 9?

edvilme avatar Jan 21 '25 17:01 edvilme