aspnetcore icon indicating copy to clipboard operation
aspnetcore copied to clipboard
verified publisher icon dotnet

Added usage of TimeProvider instead of DateTimeOffset

Open StickFun opened this issue 5 months ago • 6 comments

Added usage of TimeProvider instead of DateTimeOffset

Description

Added usage of TimeProvider for NET 8 and higher versions. Other versions using DateTimeOffset

Fixes #62796

StickFun avatar Aug 01 '25 19:08 StickFun

@dotnet-policy-service agree

StickFun avatar Aug 01 '25 19:08 StickFun

Maybe add a test that demonstrates it's used for .NET 8.0+, but otherwise looks ok to me.

Added unit test that verifies using TimeProvider

StickFun avatar Aug 07 '25 20:08 StickFun

@martincostello, do I need to rerun CI/CD myself and ping reviewer for last approve?

StickFun avatar Aug 18 '25 16:08 StickFun

If you close and reopen the PR it will run it again.

martincostello avatar Aug 20 '25 07:08 martincostello

@martincostello, is there anything else I should do to merge this PR?

StickFun avatar Aug 21 '25 16:08 StickFun

Assuming the test failures aren't due to your changes, you'll just have to wait for someone from the aspnetcore team to look at it and merge it.

martincostello avatar Aug 21 '25 16:08 martincostello