dotnet
[release/9.0] Fixed devtools url used for debug with chrome and edge
Backport of #61813 to release/9.0
/cc @javiercn @Dona278
Fixed devtools url used for debug with chrome and edge
Description
Ensures the correct creation of the devtools url with proxy to use for debug with chrome and edge browser which recently changed how urls are returned from "localhost:9222/json".
Fixes #61559
Customer Impact
Fixes a debugging issue in "debug in browser" mode.
Regression?
- [ ] Yes
- [X] No
The format of http://localhost:9222/json changed, instead of relative uri it contains an absolute one in new browser versions.
Risk
- [ ] High
- [ ] Medium
- [X] Low
It still supports the old way, just adds an additional fallback for cases of absolute paths.
Verification
- [X] Manual (required)
- [ ] Automated
Packaging changes reviewed?
- [ ] Yes
- [ ] No
- [X] N/A
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
@javiercn courtesy ping hoping that will be merged before next net9 release 🙏
@Dona278 I need to check if this is already in a public .NET 10.0 release.
We normally fix things first in a preview then backport the patch. It might take an extra patch cycle as that help us reduce risk. I have triggered the PR tests to make sure that it is ready when we decide to merge it, and I'll bring it up for consideration on the next patch cycle.
@ilonatommy were you looking at these same E2E test failures recently?
yes, it got blocked on main https://github.com/dotnet/aspnetcore/blob/5678f227fafa5dcd10b98801d4da54f1add7de6d/src/Components/test/E2ETest/ServerRenderingTests/FormHandlingTests/FormWithParentBindingContextTest.cs#L1312
I see, branch protection was elevated only for main, in backports having review + Build Analysis green is not enough to merge.
Started backporting to release/8.0: https://github.com/dotnet/aspnetcore/actions/runs/15207479105
@ilonatommy @javiercn do we need to take this one thru tactics? Ditto https://github.com/dotnet/aspnetcore/pull/62080
@wtgodbe yes, but I believe we are waiting for validation from a preview to bring it in.
Dropping the Servicing-consider label for now as this is still pending some validation.
Hi @joperezr I can image what checks have to pass a PR before merging.. but can I ask what is awaited? Maybe there is someone at work and we have to wait for a different solution? There were past 2 months, the debug with browser it totally broken, the fix is currently in preview and (I suppose) work, VS code work, VS studio work and we used the same copy-paste code in our sources because we need to debug through browser. I ask this only because I would remove the copy-paste code and allow other collugues to work with the release. Thank you and sorry for the ping
![azure-pipelines[bot] avatar](https://avatars.githubusercontent.com/in/9426?v=4 "Published by a pub.dev verified publisher"){kind=small}
We apologize folks, there was a mix-up as we are gearing for 10.0 and we didn't have the PR correctly labeled so we didn't see it.
@ilonatommy confirmed that she's done validation for this, so I will get put it on the list of candidates for the next servicing release.
@lewing @wtgodbe this can go through tactics any time now, @ilonatommy validated things.
Nice, will merge this (and the other one) once the branches re-open in a couple weeks