Fix Prefix Matching Logic in PrefixContainer
Fix Prefix Matching Logic in PrefixContainer
Description
This PR modifies the BinarySearch method in PrefixContainer to ensure that an exact match of a prefix does not incorrectly qualify as a valid prefix.
Now the ContainsPrefix method no longer gives a false positive if it has a prefix with the same name as the Action method parameter.
Fixes #57637
@sami-daniel please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@dotnet-policy-service agree [company="{your company}"]Options:
- (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@dotnet-policy-service agree
- (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@dotnet-policy-service agree company="Microsoft"Contributor License Agreement
@dotnet-policy-service agree
A small JIT-trick for better machine code.
I didn't know that, but it makes sense, thanks!
I didn't know that
The nice thing on contributing: you help to improve the product and get the opportunity to learn something new. A win - win situation 😃.
Thanks for the PR 👍🏻
I didn't know that
The nice thing on contributing: you help to improve the product and get the opportunity to learn something new. A win - win situation 😃.
Thanks for the PR 👍🏻
Yessss, C# and .NET have been my focus of study since the beginning of my interest in technology and until now I don't even know half of its power. This is my first contribution and I already loved it. Thanks!
Yessss, C# and .NET have been my focus of study since the beginning of my interest in technology and until now I don't even know half of its power. This is my first contribution and I already loved it. Thanks!
Love it, welcome @sami-daniel!
/azp run
Azure Pipelines successfully started running 3 pipeline(s).
Ubuntu failure is unrelated; it failed during node installation. cc: @dotnet/aspnet-build
##[error]Request timeout: /dist/index.json
/azp run
Commenter does not have sufficient privileges for PR 58068 in repo dotnet/aspnetcore
/azp run
Azure Pipelines successfully started running 3 pipeline(s).
Not sure if there's something making our CI more flaky than normal...
/azp run
Hello again :). Would it be possible to run the pipelines gain to see if the behavior is the same? I will make some changes if necessary
/azp run
Azure Pipelines successfully started running 3 pipeline(s).
/azp run
Azure Pipelines successfully started running 3 pipeline(s).
Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime.
To make sure no conflicting changes have occurred, please rerun validation before merging. You can do this by leaving an /azp run comment here (requires commit rights), or by simply closing and reopening.
Hi @sami-daniel.
It seems you haven't touched this PR for the last two weeks. To avoid accumulating old PRs, we're marking it as stale. As a result, it will be closed if no further activity occurs within 4 days of this comment. You can learn more about our Issue Management Policies here.
Moved to #62459 because I lost the branch where this PR was attached.