Use char overloads to Join/Index strings

Open martincostello opened this issue 1 year ago • 1 comments

Use char overloads to Join/Index strings

Use overloads that take a char for single-character strings.

Description

Use overloads that take a char for single-character strings where relevant with string.Join() or {Last}IndexOf() to resolve a number of analyser suggestions.

Also fixes a few IDE0055 diagnostics.

Jun 30 '24 09:06 martincostello

CI failure looks unrelated - that analyzer has been failing in a lot of runs.

Edit: Oh fancy, we have a bot to tag known failures now?

Jul 15 '24 19:07 amcasey

/azp run

Jul 15 '24 21:07 amcasey

Azure Pipelines successfully started running 3 pipeline(s).

Jul 15 '24 21:07 azure-pipelines[bot]