aspnetcore icon indicating copy to clipboard operation
aspnetcore copied to clipboard
verified publisher icon dotnet

Fix typos

Open martincostello opened this issue 1 year ago • 1 comments

Fix typos

Fix some test and comment typos.

Description

Spotted a typo in a test name, which lead me to the others:

"Correnct" => "Correct"
"Lenght" => "Length"

martincostello avatar Jun 30 '24 08:06 martincostello

Can you try rebasing on main @martincostello? The test failure is clearly unrelated and I wonder if it's something that was already fixed.

adityamandaleeka avatar Jul 08 '24 23:07 adityamandaleeka

cc @amcasey

adityamandaleeka avatar Jul 08 '24 23:07 adityamandaleeka

cc @amcasey

I don't recognize the failure and it also doesn't make much sense to me - it looks like the "missing" DLL was written earlier in the build.

amcasey avatar Jul 09 '24 00:07 amcasey

/azp run

amcasey avatar Jul 09 '24 00:07 amcasey

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Jul 09 '24 00:07 azure-pipelines[bot]

Rebased.

martincostello avatar Jul 09 '24 07:07 martincostello

Looks like now it ran into https://github.com/dotnet/aspnetcore/issues/53294. I wonder if we should disable that test.

adityamandaleeka avatar Jul 09 '24 17:07 adityamandaleeka

Trying one more run. If it fails again due to an unrelated reason, I'm okay with merging this on red.

adityamandaleeka avatar Jul 09 '24 17:07 adityamandaleeka