aspnetcore icon indicating copy to clipboard operation
aspnetcore copied to clipboard

Retry `Microsoft.AspNetCore.DataProtection.KeyManagement.KeyRingProviderTests.MultipleThreadsForceRefresh`

Open MackinnonBuck opened this issue 1 year ago • 5 comments

See #55227

MackinnonBuck avatar Apr 19 '24 20:04 MackinnonBuck

Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at.

The test is still failing. We should either quarantine it or, if it's not breaking a lot of people, wait for https://github.com/dotnet/aspnetcore/pull/55231. I was going to run its CI a couple more times, but I can just merge it directly to unbreak people.

amcasey avatar Apr 22 '24 17:04 amcasey

but I can just merge it directly to unbreak people.

Considering it's a code complete day, I think we should do this. Apparently the retries aren't sufficient though since the PR checks are still failing due to the test it's retrying failing repeatedly. Can we quarantine?

halter73 avatar Apr 22 '24 17:04 halter73

My preference would be to delete the test and then abandon this PR.

amcasey avatar Apr 22 '24 21:04 amcasey

Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime. To make sure no conflicting changes have occurred, please rerun validation before merging. You can do this by leaving an /azp run comment here (requires commit rights), or by simply closing and reopening.

https://github.com/dotnet/aspnetcore/pull/55290 merged instead.

BrennanConroy avatar May 16 '24 01:05 BrennanConroy