aspnetcore icon indicating copy to clipboard operation
aspnetcore copied to clipboard

Include a warning about port spoofing in xml

Open bseptember opened this issue 1 year ago • 3 comments

Include a warning about port spoofing in xml

  • [x] You've read the Contributor Guide and Code of Conduct.
  • [x] You've included unit or integration tests for your change, where applicable.
  • [x] You've included inline docs for your change, where applicable.
  • [x] There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Summary of the changes

Added remark which describes the warning as per https://learn.microsoft.com/en-us/aspnet/core/host-and-deploy/health-checks?view=aspnetcore-7.0#require-host

Description

Update API remarks for RoutingEndpointConventionBuilderExtensions.RequireHost to warn about host spoofing

Fixes #48818 (documentation changed)

bseptember avatar Apr 05 '24 13:04 bseptember

Seems like something @captainsafia would have thoughts on.

Also, do we know why those crefs aren't binding?

amcasey avatar Apr 05 '24 17:04 amcasey

@dotnet/aspnet-build CI status seems off on this PR. Can I get help merging since it's just a docs change?

captainsafia avatar Apr 08 '24 16:04 captainsafia

@bseptember It looks like there is an XML syntax issue on the PR. Would you be able to fix it? Otherwise, I can make a modification in this branch.

captainsafia avatar Apr 25 '24 19:04 captainsafia