aspnetcore icon indicating copy to clipboard operation
aspnetcore copied to clipboard

Add limit to length of IdentityUser.PhoneNumber.

Open agreentejada opened this issue 2 years ago • 1 comments

Add limit to length of IdentityUser.PhoneNumber.

  • [X] You've read the Contributor Guide and Code of Conduct.
  • [] You've included unit or integration tests for your change, where applicable.
  • [ ] You've included inline docs for your change, where applicable.
  • [ ] There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Summary of the changes (Less than 80 chars)

Description

Currently, the PhoneNumber of IdentityUser has an unlimited maximum length. The largest phone number in the world is composed of 15 digits according to https://en.wikipedia.org/wiki/E.164. For additional information such as "+, - , (,), space", a good length looks to be 50.

agreentejada avatar Jan 05 '23 07:01 agreentejada

Thanks for your PR, @agreentejada. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

ghost avatar Jan 05 '23 07:01 ghost

@HaoK PTAL

adityamandaleeka avatar Jan 23 '23 23:01 adityamandaleeka

Thanks for the PR, but this is a schema breaking change as the test failures demonstrate, this isn't something we can do without a version flag, we could add this to a list of the schema changes we can consider in .net 8 which is adding a new schema. @agreentejada can you file an issue requesting this schema update for the next identity ef model?

HaoK avatar Jan 25 '23 06:01 HaoK