aspnetcore
aspnetcore copied to clipboard
Fix logout success log message (Blazor WebAssembly)
Correct the logout log message in Blazor WASM to read "logout" instead of "login"
- [x] You've read the Contributor Guide and Code of Conduct.
- [ ] ~You've included unit or integration tests for your change, where applicable.~
- [ ] N/A ~You've included inline docs for your change, where applicable.~
- [x] There's an open issue for the PR that you are making.
- #45846
Modifies /src/Components/WebAssembly.Authentication/src/RemoteAuthenticatorViewCore.Log.cs to correct the log message and event name on successful logout.
Description
Modifies the attribute decorating the LogoutCompletedSuccessfully method in RemoteAuthenticatorViewCore.Log.cs to refer to logout, not login.
Head:
https://github.com/dotnet/aspnetcore/blob/45fcfb75dd7ca6c548200dde4f7374a9a451039b/src/Components/WebAssembly/WebAssembly.Authentication/src/RemoteAuthenticatorViewCore.Log.cs#L40-L41
This PR:
[LoggerMessage(10, LogLevel.Debug, "Logout completed successfully.", EventName = nameof(LogoutCompletedSuccessfully))]
public static partial void LogoutCompletedSuccessfully(ILogger logger);
Fixes #45846
Thanks for your PR, @mmacy. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.
Looks like you're running into some random CI flakiness, I've re-triggered the tests.
@mmacy thanks for the contribution!
@mmacy thanks for the contribution!
My pleasure, @javiercn. 🙂
Hi @mmacy. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.