aspnetcore icon indicating copy to clipboard operation
aspnetcore copied to clipboard

Localized file check-in by OneLocBuild Task: Build definition ID 1159: Build ID 2079180

Open dotnet-bot opened this issue 2 years ago • 4 comments

This is the pull request automatically created by the OneLocBuild task in the build process to check-in localized files generated based upon translation source files (.lcl files) handed-back from the downstream localization pipeline. If there are issues in translations, visit https://aka.ms/ceLocBug and log bugs for fixes. The OneLocBuild wiki is https://aka.ms/onelocbuild and the localization process in general is documented at https://aka.ms/AllAboutLoc.

dotnet-bot avatar Dec 16 '22 18:12 dotnet-bot

Almost done but the PR is not ready to merge yet based on the process described at https://github.com/dotnet/aspnetcore/pull/43599#issuecomment-1230738498

OneLocBuildClient.exe Information: 0 : [src\ProjectTemplates\Web.ProjectTemplates\content\BlazorServerWeb-CSharp\.template.config\localize\templatestrings.json] 99% localized for 13 languages.
OneLocBuildClient.exe Information: 0 : [src\ProjectTemplates\Web.ProjectTemplates\content\ComponentsWebAssembly-CSharp\.template.config\localize\templatestrings.json] 99% localized for 13 languages.
OneLocBuildClient.exe Information: 0 : [src\ProjectTemplates\Web.ProjectTemplates\content\EmptyBlazorServerWeb-CSharp\.template.config\localize\templatestrings.json] 99% localized for 13 languages.
OneLocBuildClient.exe Information: 0 : [src\ProjectTemplates\Web.ProjectTemplates\content\EmptyComponentsWebAssembly-CSharp\.template.config\localize\templatestrings.json] 99% localized for 13 languages.
OneLocBuildClient.exe Information: 0 : [src\ProjectTemplates\Web.ProjectTemplates\content\EmptyWeb-CSharp\.template.config\localize\templatestrings.json] 99% localized for 13 languages.
OneLocBuildClient.exe Information: 0 : [src\ProjectTemplates\Web.ProjectTemplates\content\EmptyWeb-FSharp\.template.config\localize\templatestrings.json] 99% localized for 13 languages.
OneLocBuildClient.exe Information: 0 : [src\ProjectTemplates\Web.ProjectTemplates\content\GrpcService-CSharp\.template.config\localize\templatestrings.json] 98% localized for 13 languages.
OneLocBuildClient.exe Information: 0 : [src\ProjectTemplates\Web.ProjectTemplates\content\RazorClassLibrary-CSharp\.template.config\localize\templatestrings.json] 97% localized for 13 languages.
OneLocBuildClient.exe Information: 0 : [src\ProjectTemplates\Web.ProjectTemplates\content\RazorPagesWeb-CSharp\.template.config\localize\templatestrings.json] 99% localized for 13 languages.
OneLocBuildClient.exe Information: 0 : [src\ProjectTemplates\Web.ProjectTemplates\content\StarterWeb-CSharp\.template.config\localize\templatestrings.json] 99% localized for 13 languages.
OneLocBuildClient.exe Information: 0 : [src\ProjectTemplates\Web.ProjectTemplates\content\StarterWeb-FSharp\.template.config\localize\templatestrings.json] 99% localized for 13 languages.
OneLocBuildClient.exe Information: 0 : [src\ProjectTemplates\Web.ProjectTemplates\content\WebApi-CSharp\.template.config\localize\templatestrings.json] 99% localized for 13 languages.
OneLocBuildClient.exe Information: 0 : [src\ProjectTemplates\Web.ProjectTemplates\content\WebApi-FSharp\.template.config\localize\templatestrings.json] 98% localized for 13 languages.
OneLocBuildClient.exe Information: 0 : [src\ProjectTemplates\Web.ProjectTemplates\content\Worker-CSharp\.template.config\localize\templatestrings.json] 97% localized for 13 languages.
OneLocBuildClient.exe Information: 0 : [src\ProjectTemplates\Web.ProjectTemplates\content\Worker-FSharp\.template.config\localize\templatestrings.json] 96% localized for 13 languages.

brunolins16 avatar Dec 16 '22 22:12 brunolins16

Do not merge

dougbu avatar Dec 29 '22 04:12 dougbu

Do not merge

What is pending on this?

captainsafia avatar Dec 29 '22 21:12 captainsafia

Do not merge

What is pending on this?

Correct translations. "Target" is no longer translated even though the related build shows the strings are 100% translated.

dougbu avatar Dec 30 '22 05:12 dougbu

Filed https://ceapex.visualstudio.com/CEINTL/_workitems/edit/762642 about the under-translation of "Target" in the Czech files.

Recent string changes should mean the builds report less than 100% translation. Even if builds get back to reporting 100%, please do not merge this PR unless the CEINTL work item has been resolved. In addition, always check the updates in loc PRs carefully to ensure we aren't regressing the translations. (That seems to happen too often, even after loc builds that report 100% translation.)

dougbu avatar Jan 06 '23 02:01 dougbu

Filed ceapex.visualstudio.com/CEINTL/_workitems/edit/762642 about the under-translation of "Target" in the Czech files.

It looks like this has been closed. Can we merge this now?

halter73 avatar Jan 18 '23 03:01 halter73

Filed ceapex.visualstudio.com/CEINTL/_workitems/edit/762642 about the under-translation of "Target" in the Czech files.

It looks like this has been closed. Can we merge this now?

I'll check this tomorrow. Have you looked in detail at the changes @halter73❔

dougbu avatar Jan 18 '23 03:01 dougbu

Had to reopen https://ceapex.visualstudio.com/CEINTL/_workitems/edit/762642 yesterday. Suspect more is still wrong w/ this PR due to a blockage somewhere in the loc process.

dougbu avatar Jan 19 '23 18:01 dougbu

Will rerun the loc build to get this PR recreated and unblock the loc fixes that are in the pipeline.

dougbu avatar Jan 26 '23 19:01 dougbu