aspnetcore icon indicating copy to clipboard operation
aspnetcore copied to clipboard

Published 20 hours ago • verified publisher icon dotnet

Fix DictionaryModelBinder null reference issue

Open brunolins16 opened this issue 2 years ago • 1 comments

Fix https://github.com/dotnet/aspnetcore/issues/45502

brunolins16 avatar Dec 09 '22 18:12 brunolins16

@dotnet/minimal-apis can you please review it 🙏.

brunolins16 avatar Jan 03 '23 18:01 brunolins16

@dotnet/minimal-apis can you please review it 🙏.

brunolins16 avatar Jan 19 '23 22:01 brunolins16

~LGTM under the assumption that I think I've grokked the changes in DictionaryModelBinder after some conversations with @brunolins16 and they seem sensible.~

LGTM -- @brunolins16 and I went through this in person today.

I will merge but wait to see the behavior in Preview 1 to start the backport.

brunolins16 avatar Jan 25 '23 00:01 brunolins16

@brunolins16 Thanks for taking care of this! Will this also be merged to aspnetcore 7? or should we skip 7 and wait for aspnetcore 8?

tomer-amir avatar Jan 25 '23 08:01 tomer-amir

Hi @tomer-amir. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

ghost avatar Jan 25 '23 08:01 ghost

@brunolins16 Thanks for taking care of this! Will this also be merged to aspnetcore 7? or should we skip 7 and wait for aspnetcore 8?

@brunolins16 referenced our backport approach in his original comment. We'll backport after we've validated the fix in .NET 8. If you'd like to help out, you can try out an upcoming nightly release (see this repo) and verify if the behavior that we changed meets expectations.

You can read more about how we do backports in this doc.

captainsafia avatar Jan 25 '23 18:01 captainsafia

Hi @brunolins16 Will this be backported on 7.0 ? we have this problem with current .net 7 version :/ Thank you

Jsl-1 avatar Oct 04 '23 15:10 Jsl-1

Hi @Jsl-1. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

ghost avatar Oct 04 '23 15:10 ghost

Hi @brunolins16 Will this be backported on 7.0 ? we have this problem with current .net 7 version :/ Thank you

Hi @Jsl-1! We typically backport issues that are high priority and don't have easy workarounds in existing languages. Given the .NET 8 release is right around the corner, I'm less inclined to backport this issue.

captainsafia avatar Oct 09 '23 23:10 captainsafia

Hi @brunolins16 Will this be backported on 7.0 ? we have this problem with current .net 7 version :/ Thank you

Hi @Jsl-1! We typically backport issues that are high priority and don't have easy workarounds in existing languages. Given the .NET 8 release is right around the corner, I'm less inclined to backport this issue.

Ok, thank you. we manage to make a dirty workaround. It can do the job waiting for the release.

Jsl-1 avatar Oct 13 '23 08:10 Jsl-1

Hi @Jsl-1. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

ghost avatar Oct 13 '23 08:10 ghost