aspnetcore icon indicating copy to clipboard operation
aspnetcore copied to clipboard

Update Roslyn versions

Open TanayParikh opened this issue 3 years ago • 2 comments

Uses the MicrosoftNetCompilersToolsetPackageVersion from https://github.com/dotnet/sdk/blob/release/7.0.1xx/eng/Versions.props.

For: https://github.com/dotnet/aspnetcore/issues/39387

Note this'll need to be back-ported to 7.0 as well.

References:

  • https://github.com/dotnet/aspnetcore/pull/28125
  • https://github.com/dotnet/aspnetcore/pull/37764

TanayParikh avatar Sep 19 '22 23:09 TanayParikh

Note this'll need to be back-ported to 7.0 as well.

I don't think these version numbers should be used in release/7.0. I believe 7.0 is supposed to run in VS 17.3, which ships 4.3.0 of these assemblies.

A better place to look to is dotnet/runtime: https://github.com/dotnet/runtime/blob/release/7.0/eng/Versions.props#L47-L51

JamesNK avatar Sep 20 '22 02:09 JamesNK

I think we should have these dependencies also called out in Version.Details.xml. That will be required for source build at some point in the .NET 8 timeframe anyway.

mmitche avatar Sep 20 '22 14:09 mmitche