aspnetcore icon indicating copy to clipboard operation
aspnetcore copied to clipboard

Localized file check-in by OneLocBuild Task: Build definition ID 1159: Build ID 2001161

Open dotnet-bot opened this issue 2 years ago • 8 comments

This is the pull request automatically created by the OneLocBuild task in the build process to check-in localized files generated based upon translation source files (.lcl files) handed-back from the downstream localization pipeline. If there are issues in translations, visit https://aka.ms/ceLocBug and log bugs for fixes. The OneLocBuild wiki is https://aka.ms/onelocbuild and the localization process in general is documented at https://aka.ms/AllAboutLoc.

dotnet-bot avatar Sep 13 '22 18:09 dotnet-bot

/azp run

brunolins16 avatar Sep 14 '22 18:09 brunolins16

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Sep 14 '22 18:09 azure-pipelines[bot]

I have followed the steps, reported here https://github.com/dotnet/aspnetcore/pull/43599#issuecomment-1230738498, and based on that we still not done yet:

OneLocBuildClient.exe Information: 0 : In summary, 99% localized for 27 resource files.

https://dev.azure.com/dnceng/internal/_build/results?buildId=1994592&view=logs&j=c0636702-cad1-5e4d-7b5b-f15c1cce530a&t=ef3c2779-04f6-5216-b20f-460f31132ece&l=983

@dougbu Is my assumption correct?

brunolins16 avatar Sep 15 '22 23:09 brunolins16

Is my assumption correct?

Yes. Bit more work to do here unfortunately.

I also checked the ToLocalizeResources.csv file produced in this morning's aspnetcore-localize build. That shows only a few of the remaining 128 strings are hardcoded values like [BundleNameSub] that should be excluded from localization.

dougbu avatar Sep 15 '22 23:09 dougbu

Is this ready?

Tratcher avatar Sep 20 '22 00:09 Tratcher

No, this isn't ready. That's because the OneLocBuild task shows the translation work is incomplete (see below) and some wording is changing. @mkArtakMSFT has volunteered to check the Russian but we haven't got people looking at the rest.

We also need to have a conversation between the leads about whether to request the loc team to leave the accelerator / accessibility / hot keys alone. See above and https://ceapex.visualstudio.com/CEINTL/_workitems/edit/709046 for details.


OneLocBuildClient.exe Information: 0 : [src\Installers\Windows\SharedFrameworkBundle\thm.wxl] 95% localized for 13 languages.
OneLocBuildClient.exe Information: 0 : [src\Installers\Windows\WindowsHostingBundle\Strings.wxl] 94% localized for 13 languages.
OneLocBuildClient.exe Information: 0 : [src\Installers\Windows\WindowsHostingBundle\thm.wxl] 98% localized for 13 languages.

(These numbers won't reach 100% w/o some exclusions for e.g. [BundleNameSub] but https://dev.azure.com/dnceng/_apis/resources/Containers/11824184/Loc?itemPath=Loc%2FToLocalizeResources.csv shows real work remains. I'm working on an exclusions PR.)

dougbu avatar Sep 20 '22 00:09 dougbu

I still see a few "translations" that are reverting to English in the WXL files. We're not quite ready to merge this or propose the fixes for 7.0.0.

@mkArtakMSFT how do the Russian updates look to you so far❔

@sebastienros if you have time, could you scan the French changes and let us know if the new translations aren't regressions (even better if they're better 😄)❔

@dotnet/aspnet-admins, @danmoseley do we have others on the team w/ fluency who could scan another language❔ @cristianosuzuki77 already looked at the Italian and pronounced it good.

dougbu avatar Sep 22 '22 22:09 dougbu

Opened [C&AI Translation Feedback] - LCL-JUNO-PROD-ASPNETCORE, some Chinese translations contain extra spaces covering the typos I commented on.

Will likely have to file another loc issue because ToLocalizeResources.csv hasn't changed in at least a week and shows simple strings like "Installation Successfully Completed". Any known issues blocking the work @jonfortescue @cristianosuzuki77❔

On the upside, files now contain fixes for problems from earlier loc PRs:

dougbu avatar Sep 23 '22 01:09 dougbu

Thanks @sebastienros❕ I filed [C&AI Translation Feedback] - LCL-JUNO-PROD-ASPNETCORE: French translations should be improved about the issues you commented on.

dougbu avatar Sep 23 '22 18:09 dougbu

Discussed the lack of progress toward completing translation of the .wxl files w/ @cristianosuzuki77 and filed [Export issue] LCL-JUNO-PROD-ASPNETCORE translations seem stuck after that discussion. Seems like a real problem on the loc backend.

dougbu avatar Sep 23 '22 19:09 dougbu

Build #20220927.1 is at 100% but we still need a fix for - ticket 712197 [C&AI Translation Feedback] - LCL-JUNO-PROD-ASPNETCORE, some Chinese translations contain extra spaces (which I reactivated). Would also be good to pick the changes from b82ff446957a47318a9d819d85e85ff7c8d36fa9 up in the translated strings.

dougbu avatar Sep 28 '22 17:09 dougbu

We are very close to this PR being ready for merging.

Build #20220928.1 picked up the b82ff446957a47318a9d819d85e85ff7c8d36fa9 changes. That reset us to being completely done except [src\Installers\Windows\SharedFrameworkBundle\thm.wxl]_ 74% localized for 13 languages. and [src\Installers\Windows\WindowsHostingBundle\thm.wxl] 81% localized for 13 languages. That is, this PR includes the #44167 fix and the reverts to English are temporary (and expected given the strings changed slightly).

In addition, fixes from ticket 712197 [C&AI Translation Feedback] - LCL-JUNO-PROD-ASPNETCORE, some Chinese translations contain extra spaces are not visible here.

dougbu avatar Sep 28 '22 19:09 dougbu

Unfortunately, I filed a few more loc tickets due to problems w/ the existing translations. See updated list at https://github.com/dotnet/aspnetcore/pull/43956#issuecomment-1258892515

dougbu avatar Oct 03 '22 03:10 dougbu

Do not merge (yet)

Blocked on completion of ticket 717656 [C&AI Translation Feedback] - LCL-JUNO-PROD-ASPNETCORE, under-translation of "directory" though ToLocResources.csv indicates all strings are completely translated.

dougbu avatar Oct 04 '22 19:10 dougbu

I think we're sufficiently unblocked to take this. While three loc issues remain open and the hot keys are changing in problematic ways, we can touch things up e.g. undoing all hot key changes when backporting to release/7.0.

I reactivated ticket 717656 [C&AI Translation Feedback] - LCL-JUNO-PROD-ASPNETCORE, under-translation of "directory" because "directory" is still not translated in src/Installers/Windows/SharedFrameworkBundle/1031/thm.wxl. We have the correct translation in src/Installers/Windows/WindowsHostingBundle/1031/thm.wxl or the old version of src/Installers/Windows/SharedFrameworkBundle/1031/thm.wxl to make that touch-up easy.

dougbu avatar Oct 14 '22 19:10 dougbu