aspnetcore
aspnetcore copied to clipboard
Localized file check-in by OneLocBuild Task: Build definition ID 1159: Build ID 2001161
This is the pull request automatically created by the OneLocBuild task in the build process to check-in localized files generated based upon translation source files (.lcl files) handed-back from the downstream localization pipeline. If there are issues in translations, visit https://aka.ms/ceLocBug and log bugs for fixes. The OneLocBuild wiki is https://aka.ms/onelocbuild and the localization process in general is documented at https://aka.ms/AllAboutLoc.
/azp run
Azure Pipelines successfully started running 3 pipeline(s).
I have followed the steps, reported here https://github.com/dotnet/aspnetcore/pull/43599#issuecomment-1230738498, and based on that we still not done yet:
OneLocBuildClient.exe Information: 0 : In summary, 99% localized for 27 resource files.
https://dev.azure.com/dnceng/internal/_build/results?buildId=1994592&view=logs&j=c0636702-cad1-5e4d-7b5b-f15c1cce530a&t=ef3c2779-04f6-5216-b20f-460f31132ece&l=983
@dougbu Is my assumption correct?
Is my assumption correct?
Yes. Bit more work to do here unfortunately.
I also checked the ToLocalizeResources.csv file produced in this morning's aspnetcore-localize
build. That shows only a few of the remaining 128 strings are hardcoded values like [BundleNameSub]
that should be excluded from localization.
Is this ready?
No, this isn't ready. That's because the OneLocBuild
task shows the translation work is incomplete (see below) and some wording is changing. @mkArtakMSFT has volunteered to check the Russian but we haven't got people looking at the rest.
We also need to have a conversation between the leads about whether to request the loc team to leave the accelerator / accessibility / hot keys alone. See above and https://ceapex.visualstudio.com/CEINTL/_workitems/edit/709046 for details.
OneLocBuildClient.exe Information: 0 : [src\Installers\Windows\SharedFrameworkBundle\thm.wxl] 95% localized for 13 languages.
OneLocBuildClient.exe Information: 0 : [src\Installers\Windows\WindowsHostingBundle\Strings.wxl] 94% localized for 13 languages.
OneLocBuildClient.exe Information: 0 : [src\Installers\Windows\WindowsHostingBundle\thm.wxl] 98% localized for 13 languages.
(These numbers won't reach 100% w/o some exclusions for e.g. [BundleNameSub]
but https://dev.azure.com/dnceng/_apis/resources/Containers/11824184/Loc?itemPath=Loc%2FToLocalizeResources.csv shows real work remains. I'm working on an exclusions PR.)
I still see a few "translations" that are reverting to English in the WXL files. We're not quite ready to merge this or propose the fixes for 7.0.0.
@mkArtakMSFT how do the Russian updates look to you so far❔
@sebastienros if you have time, could you scan the French changes and let us know if the new translations aren't regressions (even better if they're better 😄)❔
@dotnet/aspnet-admins, @danmoseley do we have others on the team w/ fluency who could scan another language❔ @cristianosuzuki77 already looked at the Italian and pronounced it good.
Opened [C&AI Translation Feedback] - LCL-JUNO-PROD-ASPNETCORE, some Chinese translations contain extra spaces covering the typos I commented on.
Will likely have to file another loc issue because ToLocalizeResources.csv hasn't changed in at least a week and shows simple strings like "Installation Successfully Completed". Any known issues blocking the work @jonfortescue @cristianosuzuki77❔
On the upside, files now contain fixes for problems from earlier loc PRs:
Thanks @sebastienros❕ I filed [C&AI Translation Feedback] - LCL-JUNO-PROD-ASPNETCORE: French translations should be improved about the issues you commented on.
Discussed the lack of progress toward completing translation of the .wxl files w/ @cristianosuzuki77 and filed [Export issue] LCL-JUNO-PROD-ASPNETCORE translations seem stuck after that discussion. Seems like a real problem on the loc backend.
some progress but at least one issue remaining
- [x] ticket 709046 [SW] Why are translations and accelerator / accessibility keys changing?
- [x] ticket 710064 [C&AI Translation Feedback] - ASP.NET Core incorrect translation
- [x] ticket 710128 [C&AI Translation Feedback] - ASP.NET Core incomplete German translation
- [x] ticket 712197 [C&AI Translation Feedback] - LCL-JUNO-PROD-ASPNETCORE, some Chinese translations contain extra spaces (supposedly resolved but not visible here)
- [x] ticket 712608 [C&AI Translation Feedback] - LCL-JUNO-PROD-ASPNETCORE: French translations should be improved (looks fixed now; @sebastienros could you double-check the 1036 files please❔
- [x] ICM 337055112 [DevDiv2][dotnet_aspnetcore][1115][Export issue] LCL-JUNO-PROD-ASPNETCORE translations seem stuck
- [ ] ticket 717075 [C&AI Translation Feedback] - LCL-JUNO-PROD-ASPNETCORE, some Japanese escaping looks invalid
- [ ] ticket 717639 [C&AI Translation Feedback] - LCL-JUNO-PROD-ASPNETCORE, over-translation of "Web Developer Tools"
- [ ] ticket 717656 [C&AI Translation Feedback] - LCL-JUNO-PROD-ASPNETCORE, under-translation of "directory"
Build #20220927.1 is at 100% but we still need a fix for - ticket 712197 [C&AI Translation Feedback] - LCL-JUNO-PROD-ASPNETCORE, some Chinese translations contain extra spaces (which I reactivated). Would also be good to pick the changes from b82ff446957a47318a9d819d85e85ff7c8d36fa9 up in the translated strings.
We are very close to this PR being ready for merging.
Build #20220928.1 picked up the b82ff446957a47318a9d819d85e85ff7c8d36fa9 changes. That reset us to being completely done except [src\Installers\Windows\SharedFrameworkBundle\thm.wxl]_ 74% localized for 13 languages.
and [src\Installers\Windows\WindowsHostingBundle\thm.wxl] 81% localized for 13 languages.
That is, this PR includes the #44167 fix and the reverts to English are temporary (and expected given the strings changed slightly).
In addition, fixes from ticket 712197 [C&AI Translation Feedback] - LCL-JUNO-PROD-ASPNETCORE, some Chinese translations contain extra spaces are not visible here.
Unfortunately, I filed a few more loc tickets due to problems w/ the existing translations. See updated list at https://github.com/dotnet/aspnetcore/pull/43956#issuecomment-1258892515
Do not merge (yet)
Blocked on completion of ticket 717656 [C&AI Translation Feedback] - LCL-JUNO-PROD-ASPNETCORE, under-translation of "directory" though ToLocResources.csv indicates all strings are completely translated.
I think we're sufficiently unblocked to take this. While three loc issues remain open and the hot keys are changing in problematic ways, we can touch things up e.g. undoing all hot key changes when backporting to release/7.0.
I reactivated ticket 717656 [C&AI Translation Feedback] - LCL-JUNO-PROD-ASPNETCORE, under-translation of "directory" because "directory" is still not translated in src/Installers/Windows/SharedFrameworkBundle/1031/thm.wxl. We have the correct translation in src/Installers/Windows/WindowsHostingBundle/1031/thm.wxl or the old version of src/Installers/Windows/SharedFrameworkBundle/1031/thm.wxl to make that touch-up easy.