aspnetcore
aspnetcore copied to clipboard
dotnet
[SignalR-Client-Cpp] Cannot properly handle invalid url
Is there an existing issue for this?
- [X] I have searched the existing issues
Describe the bug
When use a url like "/something" then start the connection,
It seems that underline lib cpprest does not allow empty host and throw the exception, but the exception does not return in the callback, instead, it terminates the program.
terminate called after throwing an instance of 'std::invalid_argument'
what(): URI must contain a hostname.
Aborted
and this cannot be catched in anyway because the function hub_connection::start(std::function<void(std::exception_ptr)> callback) noexcept; is a noexcept function
https://docs.microsoft.com/en-us/cpp/cpp/noexcept-cpp?view=msvc-170
Mark a function as noexcept only if all the functions that it calls, either directly or indirectly, are also noexcept or const. The compiler doesn't necessarily check every code path for exceptions that might bubble up to a noexcept function. If an exception does exit the outer scope of a function marked noexcept, std::terminate is invoked immediately, and there's no guarantee that destructors of any in-scope objects will be invoked.
Expected Behavior
With the mark of noexcept in hub_connection::start() function, any exceptions that might occur are expected to be in the callback.
Otherwise, it should not be marked with noexcept and let user handle any exception that might come out from it.
Steps To Reproduce
No response
Exceptions (if any)
No response
.NET Version
No response
Anything else?
No response
While we should probably fix the underlying issue, why are you trying to use /something? That won't work unless you're using the Javascript client in the browser since we can infer the current web pages host then.
It's just my use case where the app is in initial state and the server url is not yet configured, so the url might be in that format at first use.
And since my app allow free input from user (to configure their server url), I will need to be able to catch/handle this exception appropriately.
You could also look at the url before initializing the SignalR connection.
You could also look at the url before initializing the SignalR connection.
Yes, that is my workaround right now.
But anyhow, would be nice if this is addressed from the lib itself.