aspnetcore
aspnetcore copied to clipboard
Annotate WebAssembly.Authentication for nullability
Addresses https://github.com/dotnet/aspnetcore/issues/5680
@dotnet/aspnet-build How do I fix the public API files.
I tried updating just the Unshipped.txt. As an example:
*REMOVED*~Microsoft.Extensions.DependencyInjection.IRemoteAuthenticationBuilder<TRemoteAuthenticationState, TAccount>
*REMOVED*~Microsoft.Extensions.DependencyInjection.IRemoteAuthenticationBuilder<TRemoteAuthenticationState, TAccount>.Services.get -> Microsoft.Extensions.DependencyInjection.IServiceCollection
Microsoft.Extensions.DependencyInjection.IRemoteAuthenticationBuilder<TRemoteAuthenticationState, TAccount>
Microsoft.Extensions.DependencyInjection.IRemoteAuthenticationBuilder<TRemoteAuthenticationState, TAccount>.Services.get -> Microsoft.Extensions.DependencyInjection.IServiceCollection!
But I got warnings that the type exists twice. How do I fix this?
Warning RS0025 The symbol 'Microsoft.Extensions.DependencyInjection.IRemoteAuthenticationBuilder<TRemoteAuthenticationState, TAccount>' appears more than once in the public API files Microsoft.AspNetCore.Components.WebAssembly.Authentication C:\Development\Source\aspnetcore\src\Components\WebAssembly\WebAssembly.Authentication\src\PublicAPI.Unshipped.txt 32 Active
Update the shipped.txt file in this case. The analyzer doesn't work well when going from non-nullable to nullable APIs.
@dotnet/aspnet-build How do I make the build pass with the shipped.txt changes?
How do I make the build pass with the shipped.txt changes?
You don't. Someone with permissions will need to merge.
@dotnet/aspnet-blazor-eng Please review
@mkArtakMSFT
Thanks @JamesNK. @MackinnonBuck can you please review this? Thanks!
I'd like to be able to merge this. Can the SME please review and approve/require changes 🙏
@JamesNK let me take a look.
@JamesNK let me take a look.
@javiercn ping
Annotate WebAssembly.Authentication for nullability #43442