aspnetcore icon indicating copy to clipboard operation
aspnetcore copied to clipboard

Annotate WebAssembly.Authentication for nullability

Open JamesNK opened this issue 3 years ago • 5 comments
trafficstars

Addresses https://github.com/dotnet/aspnetcore/issues/5680

JamesNK avatar Aug 22 '22 06:08 JamesNK

@dotnet/aspnet-build How do I fix the public API files.

I tried updating just the Unshipped.txt. As an example:

*REMOVED*~Microsoft.Extensions.DependencyInjection.IRemoteAuthenticationBuilder<TRemoteAuthenticationState, TAccount>
*REMOVED*~Microsoft.Extensions.DependencyInjection.IRemoteAuthenticationBuilder<TRemoteAuthenticationState, TAccount>.Services.get -> Microsoft.Extensions.DependencyInjection.IServiceCollection

Microsoft.Extensions.DependencyInjection.IRemoteAuthenticationBuilder<TRemoteAuthenticationState, TAccount>
Microsoft.Extensions.DependencyInjection.IRemoteAuthenticationBuilder<TRemoteAuthenticationState, TAccount>.Services.get -> Microsoft.Extensions.DependencyInjection.IServiceCollection!

But I got warnings that the type exists twice. How do I fix this?

Warning RS0025 The symbol 'Microsoft.Extensions.DependencyInjection.IRemoteAuthenticationBuilder<TRemoteAuthenticationState, TAccount>' appears more than once in the public API files Microsoft.AspNetCore.Components.WebAssembly.Authentication C:\Development\Source\aspnetcore\src\Components\WebAssembly\WebAssembly.Authentication\src\PublicAPI.Unshipped.txt 32 Active

JamesNK avatar Aug 22 '22 09:08 JamesNK

Update the shipped.txt file in this case. The analyzer doesn't work well when going from non-nullable to nullable APIs.

BrennanConroy avatar Aug 22 '22 16:08 BrennanConroy

@dotnet/aspnet-build How do I make the build pass with the shipped.txt changes?

JamesNK avatar Aug 23 '22 08:08 JamesNK

How do I make the build pass with the shipped.txt changes?

You don't. Someone with permissions will need to merge.

BrennanConroy avatar Aug 23 '22 15:08 BrennanConroy

@dotnet/aspnet-blazor-eng Please review

JamesNK avatar Sep 21 '22 23:09 JamesNK

@mkArtakMSFT

JamesNK avatar Sep 24 '22 01:09 JamesNK

Thanks @JamesNK. @MackinnonBuck can you please review this? Thanks!

mkArtakMSFT avatar Oct 02 '22 14:10 mkArtakMSFT

I'd like to be able to merge this. Can the SME please review and approve/require changes 🙏

JamesNK avatar Oct 17 '22 07:10 JamesNK

@JamesNK let me take a look.

javiercn avatar Oct 17 '22 12:10 javiercn

@JamesNK let me take a look.

javiercn avatar Oct 17 '22 12:10 javiercn

@javiercn ping

JamesNK avatar Nov 02 '22 06:11 JamesNK

Annotate WebAssembly.Authentication for nullability #43442

japui-coder avatar Nov 03 '22 04:11 japui-coder