aspire icon indicating copy to clipboard operation
aspire copied to clipboard

[tests] Clean up test run for EndToEnd tests

Open radical opened this issue 8 months ago • 3 comments

This has a single scenario being used, and the helix targets file and the test project can be simplified now.

Once https://github.com/dotnet/aspire/pull/8498 is merged, and this issue is done remove the --ignore-exit-code 8 from the test arguments.

radical avatar Apr 09 '25 00:04 radical

@radical looks like #8498 is done now, is there still something that we need to do here?

joperezr avatar Apr 15 '25 17:04 joperezr

@radical looks like #8498 is done now, is there still something that we need to do here?

Yeah, we are still ignoring the exit code. IIUC, this is part of what @RussKie is working on.

radical avatar Apr 15 '25 19:04 radical

I'm not exactly clear on the ask here.

In the runsheet-testing scenarios there are legitimate reasons to use --ignore-exit-code 8 - e.g., in the outerloop where we know a test project contains quarantined tests, but we don't know whether any of those are runnable on a given OS. E.g., those that require docker integration, which is only available on Ubuntu, so the Windows leg may result in no tests run, thus exiting with code 8.

RussKie avatar Apr 22 '25 08:04 RussKie