Follow up tasks for the move to xunit v3
Follow up work for https://github.com/dotnet/aspire/pull/8403:
- [ ] Re-enable
xunit1051warning, and fix the instances (xUnit1051: Calls to methods which accept CancellationToken should use TestContext.Current.CancellationToken) - [ ] Re-enable
xunit2031also. (xUnit2031: Do not use Where clause with Assert.Single) - [ ] Explore what bits can/should be updated in the repo to use v3 well
cc @Youssef1313 @RussKie
Where you planning on taking this one for 9.3 @radical ?
Where you planning on taking this one for 9.3 @radical ?
I wasn't. I had opened this to track follow up work required from https://github.com/dotnet/aspire/pull/8403 as discussed, so it doesn't get missed. cc @RussKie
Re-enable xunit1051 warning, and fix the instances (xUnit1051: Calls to methods which accept CancellationToken should use TestContext.Current.CancellationToken)
implemented Open next PRs #8951 #8953 #8954 #8955 #8956
@radical "Re-enable xunit2031 also. (xUnit2031: Do not use Where clause with Assert.Single)" Also ready
per #9020 , we think xunit1051 is best left disabled right now.
all that is left is
Explore what bits can/should be updated in the repo to use v3 well
@radical not sure what this is. shall we close this issue
all that is left is
Explore what bits can/should be updated in the repo to use v3 well
@radical not sure what this is. shall we close this issue
This was about exploring MTP retries or any other features that might be useful. But I close this issue, and if we come across any feature that we want to use then specific issues can be opened up.