aspire icon indicating copy to clipboard operation
aspire copied to clipboard

Follow up tasks for the move to xunit v3

Open radical opened this issue 9 months ago • 5 comments

Follow up work for https://github.com/dotnet/aspire/pull/8403:

  • [ ] Re-enable xunit1051 warning, and fix the instances (xUnit1051: Calls to methods which accept CancellationToken should use TestContext.Current.CancellationToken)
  • [ ] Re-enable xunit2031 also. (xUnit2031: Do not use Where clause with Assert.Single)
  • [ ] Explore what bits can/should be updated in the repo to use v3 well

cc @Youssef1313 @RussKie

radical avatar Apr 01 '25 23:04 radical

Where you planning on taking this one for 9.3 @radical ?

joperezr avatar Apr 15 '25 17:04 joperezr

Where you planning on taking this one for 9.3 @radical ?

I wasn't. I had opened this to track follow up work required from https://github.com/dotnet/aspire/pull/8403 as discussed, so it doesn't get missed. cc @RussKie

radical avatar Apr 15 '25 19:04 radical

Re-enable xunit1051 warning, and fix the instances (xUnit1051: Calls to methods which accept CancellationToken should use TestContext.Current.CancellationToken)

implemented Open next PRs #8951 #8953 #8954 #8955 #8956

illay1994 avatar Apr 24 '25 21:04 illay1994

@radical "Re-enable xunit2031 also. (xUnit2031: Do not use Where clause with Assert.Single)" Also ready

Zombach avatar Apr 27 '25 19:04 Zombach

per #9020 , we think xunit1051 is best left disabled right now.

danmoseley avatar Apr 29 '25 20:04 danmoseley

all that is left is

Explore what bits can/should be updated in the repo to use v3 well

@radical not sure what this is. shall we close this issue

danmoseley avatar May 10 '25 15:05 danmoseley

all that is left is

Explore what bits can/should be updated in the repo to use v3 well

@radical not sure what this is. shall we close this issue

This was about exploring MTP retries or any other features that might be useful. But I close this issue, and if we come across any feature that we want to use then specific issues can be opened up.

radical avatar May 30 '25 01:05 radical