aspire icon indicating copy to clipboard operation
aspire copied to clipboard

Add health check support for Qdrant client

Open Alirexaa opened this issue 1 year ago • 2 comments

Description

This PR Adds health check support for Aspire.Qdrant.Client.

We need to import Testcontainers for ConformanceTests.

Fixes #5768

Checklist

  • Is this feature complete?
    • [X] Yes. Ready to ship.
    • [ ] No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • [X] Yes
    • [ ] No
  • Did you add public API?
    • [X] Yes
      • If yes, did you have an API Review for it?
        • [X] Yes
        • [ ] No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • [ ] Yes
        • [X] No
    • [ ] No
  • Does the change make any security assumptions or guarantees?
    • [ ] Yes
      • If yes, have you done a threat model and had a security review?
        • [ ] Yes
        • [ ] No
    • [X] No
  • Does the change require an update in our Aspire docs?
    • [X] Yes
      • Link to aspire-docs issue:
    • [ ] No
Microsoft Reviewers: Open in CodeFlow

Alirexaa avatar Oct 01 '24 20:10 Alirexaa

/azp run

radical avatar Oct 03 '24 05:10 radical

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Oct 03 '24 05:10 azure-pipelines[bot]

I still have this problem https://github.com/dotnet/aspire/pull/6432#issuecomment-2429935302 @eerhardt can you help me fix that?

Alirexaa avatar Oct 30 '24 18:10 Alirexaa

I still have this problem #6432 (comment) @eerhardt can you help me fix that?

From the root of your repo, run the following and ensure you get the same output:

❯ dotnet nuget list source
Registered Sources:
  1.  dotnet-public [Enabled]
      https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-public/nuget/v3/index.json
  2.  dotnet-eng [Enabled]
      https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-eng/nuget/v3/index.json
  3.  dotnet9 [Enabled]
      https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet9/nuget/v3/index.json
  4.  dotnet-libraries [Enabled]
      https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-libraries/nuget/v3/index.json
  5.  dotnet9-transport [Enabled]
      https://dnceng.pkgs.visualstudio.com/public/_packaging/dotnet9-transport/nuget/v3/index.json

If any of those are disabled, make sure you enable them, usually in VS: Tools => NuGet Package Manager => Package Manager Settings => Package Sources.

eerhardt avatar Oct 30 '24 19:10 eerhardt

I still have this problem #6432 (comment) @eerhardt can you help me fix that?

From the root of your repo, run the following and ensure you get the same output:

❯ dotnet nuget list source
Registered Sources:
  1.  dotnet-public [Enabled]
      https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-public/nuget/v3/index.json
  2.  dotnet-eng [Enabled]
      https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-eng/nuget/v3/index.json
  3.  dotnet9 [Enabled]
      https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet9/nuget/v3/index.json
  4.  dotnet-libraries [Enabled]
      https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-libraries/nuget/v3/index.json
  5.  dotnet9-transport [Enabled]
      https://dnceng.pkgs.visualstudio.com/public/_packaging/dotnet9-transport/nuget/v3/index.json

If any of those are disabled, make sure you enable them, usually in VS: Tools => NuGet Package Manager => Package Manager Settings => Package Sources.

Thanks a lot.

Alirexaa avatar Oct 30 '24 19:10 Alirexaa