aspire icon indicating copy to clipboard operation
aspire copied to clipboard

additional dashpages changes

Open adamint opened this issue 1 year ago • 7 comments

This includes a merge of main into this branch at the end to resolve outstanding conflicts. I know the diff is large. However, you can ignore all but the last/3rd/4th/5th/6th/7th commits, which are all small and isolated to fix the issue in their commit names.

  • consistently sort dashpages in the overall dashpages page
  • rename name to display name, add id parameter to DashpageDefinition and use id where appropriate
  • rename Dashpages to Highlights, update the query parameter and path parameter from dashpage/dashpages to highlight/highlights
Microsoft Reviewers: Open in CodeFlow

adamint avatar Oct 01 '24 17:10 adamint

@drewnoakes

adamint avatar Oct 01 '24 17:10 adamint

Seems the test PlotlyChartTests.Render_NoInstrument_NoPlotlyInvocations is failing due to differences in HTML.

drewnoakes avatar Oct 01 '24 21:10 drewnoakes

Could you rebase on the branch you're merging to? Looking through commits makes reviewing harder. And you automatically include a bunch of unrelated people to review:

image

JamesNK avatar Oct 02 '24 01:10 JamesNK

Could you rebase on the branch you're merging to? Looking through commits makes reviewing harder. And you automatically include a bunch of unrelated people to review:

@adamint for the other merges from main I've just pushed directly to the feature branch, after checking that everything builds/passes locally.

drewnoakes avatar Oct 02 '24 02:10 drewnoakes

Added a warning comment, updated APIs -> highlights

adamint avatar Oct 02 '24 18:10 adamint

/azp run

radical avatar Oct 03 '24 05:10 radical

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Oct 03 '24 05:10 azure-pipelines[bot]

/azp run

adamint avatar Oct 08 '24 14:10 adamint

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Oct 08 '24 14:10 azure-pipelines[bot]