aspire icon indicating copy to clipboard operation
aspire copied to clipboard
verified publisher icon dotnet

[tests] More Conformance tests should use `Testcontainers`

Open radical opened this issue 1 year ago • 1 comments

.. similar to how others do this.

https://github.com/dotnet/aspire/blob/44a60c18d9d77110ca0aa3b753476510e4823eb2/tests/Aspire.StackExchange.Redis.Tests/RedisContainerFixture.cs#L11-L43 https://github.com/dotnet/aspire/blob/44a60c18d9d77110ca0aa3b753476510e4823eb2/tests/Aspire.StackExchange.Redis.Tests/ConformanceTests.cs#L18-L19

Currently any tests that need to connect get skipped with Unable to connect to server.

  • [ ] Qdrant
  • [ ] RabbitMq
  • [ ] Aspire.Microsoft.EntityFrameworkCore.Cosmos.Tests.

cc @eerhardt @sebastienros @joperezr

radical avatar Aug 10 '24 02:08 radical

Qdrant

See https://github.com/testcontainers/testcontainers-dotnet/issues/992

RabbitMq

RabbitMQ is already using testcontainers:

https://github.com/dotnet/aspire/blob/fecfe0ac15c24de0d569714e64d255efd9a42332/tests/Aspire.RabbitMQ.Client.Tests/RabbitMQContainerFixture.cs#L34-L38

eerhardt avatar Aug 12 '24 15:08 eerhardt

Qdrant was done with #6057.

Closing this as the only one left is CosmosDB EF tests. The value is minimal of converting the tests to use it.

eerhardt avatar Jan 14 '25 21:01 eerhardt