aspire icon indicating copy to clipboard operation
aspire copied to clipboard

Correct XML Docs for `RabbitMqServerResource.PrimaryEndpoint`

Open afscrome opened this issue 9 months ago • 8 comments

It's a RabbitMQ server, not redis 😉.

Microsoft Reviewers: Open in CodeFlow

afscrome avatar May 08 '24 07:05 afscrome

thanks. there's a bunch of copy/pastes of "Gets the primary endpoint for the Redis server." .. can you fix others as needed?

danmoseley avatar May 08 '24 17:05 danmoseley

Also see one for PostgreSQL as a copy/paste typo as well here.

timheuer avatar May 09 '24 03:05 timheuer

Yea, there are a few - https://github.com/search?q=repo%3Adotnet%2Faspire%20%22Gets%20the%20primary%20endpoint%20for%20the%20Redis%20server%22&type=code .

I can have a look but it may not be until the weekend. If you want to merge this PR in it's current form feel frere and I'll follow up with a second PR. Otherwise I'll append to this one.

afscrome avatar May 09 '24 10:05 afscrome

@afscrome ironically our edits made this large enough we need you to agree to the CLA . Could you do that? You'd probably have needed to do it for the next PR anyway. You only need to do it once.

danmoseley avatar May 09 '24 17:05 danmoseley

One of my collogues has already signed the CLA for our company - https://github.com/dotnet/sign/pull/656#issuecomment-1957227841 . Do I need to do something to link my account to the company or do I need to agree again.

afscrome avatar May 14 '24 14:05 afscrome

I believe the bot requires it from every account. But only once each

danmoseley avatar May 16 '24 03:05 danmoseley

Note you just have to leave the indicated comment right here in this PR thread

danmoseley avatar May 16 '24 03:05 danmoseley

@dotnet-policy-service agree company="Trayport"

afscrome avatar May 20 '24 14:05 afscrome