aspire icon indicating copy to clipboard operation
aspire copied to clipboard
verified publisher icon dotnet

Create integration tests for the rest of the Components

Open eerhardt opened this issue 1 year ago • 2 comments

We are missing the EntityFramework components in our functional integration tests added in #1217. We should add them, plus any other missing components that would be valuable.

TODO:

  • [ ] efsqlserver
  • [x] efpostgres
  • [ ] efcosmos
  • [ ] eforacle

eerhardt avatar Jan 05 '24 21:01 eerhardt

Is this referring to:

https://github.com/dotnet/aspire/blob/eb08a4ab513215503ec4a4b87dba8ceae17e368b/tests/Aspire.EndToEnd.Tests/IntegrationServicesTests.cs#L18-L34

So, essentially connect, and try some basic operation?

radical avatar Feb 12 '24 23:02 radical

Correct. There are components that aren't covered in those tests - like the EF postgres and sql server components.

eerhardt avatar Feb 20 '24 22:02 eerhardt

@eerhardt is this issue stale? Are we still missing some test coverage here? If so, is 8.1 the right milestone? I don't think that Ankit is currently looking into this.

joperezr avatar Jun 17 '24 18:06 joperezr

is this issue stale? Are we still missing some test coverage here?

I'm not sure what you mean by "stale", but this issue is still relevant. We don't have these integration tests yet. So yes we are missing some test coverage here.

If so, is 8.1 the right milestone?

Yes, I believe so. We want better test coverage in 8.1.

eerhardt avatar Jun 17 '24 23:06 eerhardt

Last ones completed by https://github.com/dotnet/aspire/pull/4758 .

radical avatar Jul 03 '24 17:07 radical