aspire icon indicating copy to clipboard operation
aspire copied to clipboard

Added support for non-Public cloud in Azure App Service

Open ShilpiRach opened this issue 2 months ago • 1 comments

Description

Added the support to derive App Service DNS Suffix from Cloud name. It adds a new optional parameter to AddAzureAppServiceEnvironment method (with Azure public cloud as the default).

The intent is to remove the current hardcoding of App Servic endpoint to https:\\<app service name>.azurewebsites.net irrespective of cloud.

Fixes # (issue)

Checklist

  • Is this feature complete?
    • [ ] Yes. Ready to ship.
    • [ ] No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • [ ] Yes
    • [ ] No
  • Did you add public API?
    • [ ] Yes
      • If yes, did you have an API Review for it?
        • [ ] Yes
        • [ ] No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • [ ] Yes
        • [ ] No
    • [ ] No
  • Does the change make any security assumptions or guarantees?
    • [ ] Yes
      • If yes, have you done a threat model and had a security review?
        • [ ] Yes
        • [ ] No
    • [ ] No
  • Does the change require an update in our Aspire docs?

ShilpiRach avatar Oct 27 '25 14:10 ShilpiRach

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 12403

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 12403"

github-actions[bot] avatar Oct 27 '25 14:10 github-actions[bot]