arcade icon indicating copy to clipboard operation
arcade copied to clipboard

Published 20 hours ago • verified publisher icon dotnet

TestResults table should be deprecated

Open dotnet-bot opened this issue 2 years ago • 4 comments

Migrated from https://github.com/dotnet/core-eng/issues/14679

@markwilkie wrote:

From Chad:

[10:50 AM] Chad Nedzlek There appear to be 2 pieces of server code that still populates it. One of them should just be copies of the AzDO tests with a hard coded "Fail". The other is from the reporter I deleted from arcade, so either someone has a copy of it, or someone hasn't updated arcade. ​[10:50 AM] Chad Nedzlek Once people use the new table, we should delete those 2 pieces of code. ​[10:51 AM] Chad Nedzlek We should consider doing https://github.com/dotnet/core-eng/issues/14551 first. <https://teams.microsoft.com/l/message/19:[email protected]/1634665825594?tenantId=72f988bf-86f1-41af-91ab-2d7cd011db47&groupId=4d73664c-9f2f-450d-82a5-c2f02756606d&parentMessageId=1634577446851&teamName=.NET Core Eng Services Partners&channelName=General&createdTime=1634665825594>

dotnet-bot avatar Apr 07 '22 20:04 dotnet-bot

Working with the product teams to ensure this can be done safely.

missymessa avatar Apr 27 '22 21:04 missymessa

We also need to wait for this fix to rollout in AzDO before we can deprecate this table: https://dev.azure.com/mseng/AzureDevOps/_workitems/edit/1943353

missymessa avatar Jul 12 '22 15:07 missymessa

(Also, reached out to the product teams this week and haven't gotten any push back on deprecating the TestResults table).

missymessa avatar Jul 12 '22 15:07 missymessa

Poked on the IcM for an update.

missymessa avatar Sep 20 '22 15:09 missymessa

Following up: AzDO had a conversation with one of our product team customers and came to an agreement of how to further improve the searching, especially when there are millions of test results.

missymessa avatar Oct 20 '22 17:10 missymessa

Update: reached out to Karel who said that his team is no longer using TestResults, so we're good to go on deprecation. Will follow up with Chad about it after the holidays to see what all needs to be done here and do it :) (e.g. making sure that once it's deleted we're not going to see errors from things attempting to be inserted into it).

missymessa avatar Dec 12 '22 20:12 missymessa

Plan:

  1. Get https://dnceng.visualstudio.com/internal/_git/dotnet-helix-service/pullrequest/21134 merged in.
  2. Rename the table to something else as a soft-delete
  3. If no issues, delete the table.

Contingencies:

  1. Revert the PR if something goes sideways here.
  2. Revert the rename if something goes wrong here.
  3. At this point, any issues should have surfaced. Deletion should be straightforward.

missymessa avatar Jan 03 '23 23:01 missymessa

Chad's PR has been merged. Will follow up after that change has been rolled out to rename the table.

missymessa avatar Jan 04 '23 19:01 missymessa

JUST renamed both TestResults tables in staging and prod Kusto clusters to DEPRECATEDTestResults. We'll give it a week to see if anything blows up and if not, delete!

missymessa avatar Jan 23 '23 23:01 missymessa

Dropped DEPRECATEDTestResults from both staging and prod. Closing this issue.

missymessa avatar Jan 31 '23 18:01 missymessa

nice!

markwilkie avatar Feb 02 '23 15:02 markwilkie