arcade
arcade copied to clipboard
Change Warning to Information in Azure Helper retry code.
https://github.com/dotnet/arcade/blob/master/src/Microsoft.DotNet.Build.Tasks.Feed/src/common/AzureHelper.cs#L244
try
{
using (var request = createRequest())
response = await client.SendAsync(request);
}
catch (Exception e)
{
loggingHelper.LogWarningFromException(e, true);
// if this is the final iteration let the exception bubble up
if (retries + 1 == retryCount)
throw;
}
Unfortunately there are lots of builds which have settings to treat warnings as errors, leading to this retry logic not being very helpful.
I recommend we make this a LogInformation() type call but with the string "warning" so folks don't think it's good that their build had to retry.
@chcosta FYI.
Moving to post P7