DownloadWithRetriesAsync seems to retry, but still log an error?

[ericstj]

Seems to be a retryable exception in https://dev.azure.com/dnceng/internal/_build/results?buildId=2792361&view=logs&j=89eea50f-59b5-5921-c3ce-ce40b36fa819&t=483e1309-93e4-5a7a-74de-93b8d658274f&l=11782

I assume it retried and succeeded since I see the build produce an MSI cc @joeloff

The build was still marked as a failure, most likely because of the logged exception: https://github.com/dotnet/arcade/blob/c32cd132a730a7b9f947498b2ae75dbdc6785456/src/Microsoft.DotNet.Arcade.Sdk/src/DownloadFile.cs#L222

Pretty sure that LogError should only be in the return false path. @lewing you added in https://github.com/dotnet/arcade/commit/025a2b3851dbc4d07d7a52f70dac557956196622

 D:\a\_work\1\s\src\runtime\artifacts\.packages\microsoft.dotnet.build.tasks.installers\11.0.0-beta.25462.113\build\acquisition\acquire-wix\acquire-wix.proj(36,5): error : HttpRequestException: No connection could be made because the target machine actively refused it. (netcorenativeassets.blob.core.windows.net:443)
  D:\a\_work\1\s\src\runtime\artifacts\.packages\microsoft.dotnet.build.tasks.installers\11.0.0-beta.25462.113\build\acquisition\acquire-wix\acquire-wix.proj(36,5): error :    at System.Net.Http.HttpConnectionPool.ConnectToTcpHostAsync(String host, Int32 port, HttpRequestMessage initialRequest, Boolean async, CancellationToken cancellationToken)
  D:\a\_work\1\s\src\runtime\artifacts\.packages\microsoft.dotnet.build.tasks.installers\11.0.0-beta.25462.113\build\acquisition\acquire-wix\acquire-wix.proj(36,5): error :    at System.Net.Http.HttpConnectionPool.ConnectAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
  D:\a\_work\1\s\src\runtime\artifacts\.packages\microsoft.dotnet.build.tasks.installers\11.0.0-beta.25462.113\build\acquisition\acquire-wix\acquire-wix.proj(36,5): error :    at System.Net.Http.HttpConnectionPool.CreateHttp11ConnectionAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
  D:\a\_work\1\s\src\runtime\artifacts\.packages\microsoft.dotnet.build.tasks.installers\11.0.0-beta.25462.113\build\acquisition\acquire-wix\acquire-wix.proj(36,5): error :    at System.Net.Http.HttpConnectionPool.InjectNewHttp11ConnectionAsync(QueueItem queueItem)
  D:\a\_work\1\s\src\runtime\artifacts\.packages\microsoft.dotnet.build.tasks.installers\11.0.0-beta.25462.113\build\acquisition\acquire-wix\acquire-wix.proj(36,5): error :    at System.Threading.Tasks.TaskCompletionSourceWithCancellation`1.WaitWithCancellationAsync(CancellationToken cancellationToken)
  D:\a\_work\1\s\src\runtime\artifacts\.packages\microsoft.dotnet.build.tasks.installers\11.0.0-beta.25462.113\build\acquisition\acquire-wix\acquire-wix.proj(36,5): error :    at System.Net.Http.HttpConnectionPool.SendWithVersionDetectionAndRetryAsync(HttpRequestMessage request, Boolean async, Boolean doRequestAuth, CancellationToken cancellationToken)
  D:\a\_work\1\s\src\runtime\artifacts\.packages\microsoft.dotnet.build.tasks.installers\11.0.0-beta.25462.113\build\acquisition\acquire-wix\acquire-wix.proj(36,5): error :    at System.Net.Http.RedirectHandler.SendAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
  D:\a\_work\1\s\src\runtime\artifacts\.packages\microsoft.dotnet.build.tasks.installers\11.0.0-beta.25462.113\build\acquisition\acquire-wix\acquire-wix.proj(36,5): error :    at System.Net.Http.SocketsHttpHandler.<SendAsync>g__CreateHandlerAndSendAsync|115_0(HttpRequestMessage request, CancellationToken cancellationToken)
  D:\a\_work\1\s\src\runtime\artifacts\.packages\microsoft.dotnet.build.tasks.installers\11.0.0-beta.25462.113\build\acquisition\acquire-wix\acquire-wix.proj(36,5): error :    at System.Net.Http.HttpClient.<SendAsync>g__Core|83_0(HttpRequestMessage request, HttpCompletionOption completionOption, CancellationTokenSource cts, Boolean disposeCts, CancellationTokenSource pendingRequestsCts, CancellationToken originalCancellationToken)
  D:\a\_work\1\s\src\runtime\artifacts\.packages\microsoft.dotnet.build.tasks.installers\11.0.0-beta.25462.113\build\acquisition\acquire-wix\acquire-wix.proj(36,5): error :    at Microsoft.DotNet.Arcade.Sdk.DownloadFile.DownloadWithRetriesAsync(HttpClient httpClient, String uri) in /_/src/arcade/src/Microsoft.DotNet.Arcade.Sdk/src/DownloadFile.cs:line 184
  D:\a\_work\1\s\src\runtime\artifacts\.packages\microsoft.dotnet.build.tasks.installers\11.0.0-beta.25462.113\build\acquisition\acquire-wix\acquire-wix.proj(36,5): error : SocketException: No connection could be made because the target machine actively refused it.
  D:\a\_work\1\s\src\runtime\artifacts\.packages\microsoft.dotnet.build.tasks.installers\11.0.0-beta.25462.113\build\acquisition\acquire-wix\acquire-wix.proj(36,5): error :    at System.Net.Sockets.Socket.AwaitableSocketAsyncEventArgs.ThrowException(SocketError error, CancellationToken cancellationToken)
  D:\a\_work\1\s\src\runtime\artifacts\.packages\microsoft.dotnet.build.tasks.installers\11.0.0-beta.25462.113\build\acquisition\acquire-wix\acquire-wix.proj(36,5): error :    at System.Net.Sockets.Socket.AwaitableSocketAsyncEventArgs.System.Threading.Tasks.Sources.IValueTaskSource.GetResult(Int16 token)
  D:\a\_work\1\s\src\runtime\artifacts\.packages\microsoft.dotnet.build.tasks.installers\11.0.0-beta.25462.113\build\acquisition\acquire-wix\acquire-wix.proj(36,5): error :    at System.Net.Http.HttpConnectionPool.ConnectToTcpHostAsync(String host, Int32 port, HttpRequestMessage initialRequest, Boolean async, CancellationToken cancellationToken)
  D:\a\_work\1\s\src\runtime\artifacts\.packages\microsoft.dotnet.build.tasks.installers\11.0.0-beta.25462.113\build\acquisition\acquire-wix\acquire-wix.proj(36,5): error : 
      0 Warning(s)
      1 Error(s)

[lewing]

the details escape me right now, but I believe we were trying to capture more details about an intermittent exception.