arcade icon indicating copy to clipboard operation
arcade copied to clipboard

Arcade's signing settings are wrong when setting UsingToolXliff=false

Open ericstj opened this issue 7 months ago • 1 comments

Looks like the old msbuild uses AL to produce satellite assemblies. AL doesn't support publicsign which Arcade targets rely on when building assemblies that sign with various PRSS-owned signing keys.

Arcade should either set GenerateSatelliteAssembliesForCore for all projects regardless of UsingToolXliff setting, or it should use a different value for DelaySign when running AL.

I'm not sure if AL has any features that would be missing from core approach of using csc. If not, then I'd suggest we just use GenerateSatelliteAssembliesForCore always.

ericstj avatar May 22 '25 19:05 ericstj

It seems like the old Al task had a lot of user-provided extension points: https://github.com/dotnet/msbuild/blob/f88eb76608c0e4417aa066c20e698a9174855df0/src/Tasks/Microsoft.Common.CurrentVersion.targets#L4091-L4124C26

But the new CSC task gets most f it's input from the generated AssemblyInfo file and shared properties: https://github.com/dotnet/sdk/blob/3c8028693b521eecff36883803ee48b6bd96b8cb/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.targets#L1225-L1248

IMO Arcade can opt people into the new method. cc @rainersigwald @mmitche @dsplaisted

ericstj avatar May 22 '25 19:05 ericstj