arcade icon indicating copy to clipboard operation
arcade copied to clipboard

Remove legacy source-build switches

Open mmitche opened this issue 1 year ago • 4 comments

To double check:

  • [ ] The right tests are in and the right validation has happened. Guidance: https://github.com/dotnet/arcade/blob/main/Documentation/Validation.md

mmitche avatar Oct 10 '24 21:10 mmitche

Resolves https://github.com/dotnet/source-build/issues/4182

mmitche avatar Oct 10 '24 21:10 mmitche

The scope of https://github.com/dotnet/source-build/issues/4182 is not clear. What is tracking the removal of ExcludeFromSourceBuild? I don't see any other issue in https://github.com/dotnet/source-build/issues/2975 that would include this besides https://github.com/dotnet/source-build/issues/4182. I am asking if https://github.com/dotnet/source-build/issues/4182 should remain open until this is done?

MichaelSimons avatar Oct 14 '24 14:10 MichaelSimons

ExcludeFromSourceBuild is tracked by https://github.com/dotnet/source-build/issues/4182. It should be gone with this PR.

mmitche avatar Oct 14 '24 18:10 mmitche

I still see a couple remaining usages so holding off on merging this.

mmitche avatar Oct 14 '24 18:10 mmitche