Flow NuGetPackageRoot out of Tools.proj restore

Open tmat opened this issue 1 year ago • 4 comments

Jun 20 '24 20:06 tmat

I think this is okay, but I think it would be good to verify source builds. Can you push a branch to the AzDO dotnet-dotnet repo with those changes to arcade (src\arcade) and run https://dev.azure.com/dnceng/internal/_build?definitionId=1219 (internal link).

/cc @ViktorHofer @dotnet/source-build-internal

Jun 21 '24 22:06 mmitche

lgtm

Jun 24 '24 23:06 tmat

@sharwell @tmat Can you add a description for why this change is necessary? What is the root purpose?

Jun 27 '24 15:06 mmitche

@mmitche This pull request is a prerequisite to using #14883 to fix #14761.

Jun 28 '24 16:06 sharwell