Update to May Servicing

Open mmitche opened this issue 1 year ago • 4 comments

To double check:

[ ] The right tests are in and and the right validation has happened. Guidance: https://github.com/dotnet/arcade/tree/main/Documentation/Validation

Apr 09 '24 20:04 mmitche

@mmitche did you want to merge this?

Apr 23 '24 14:04 ViktorHofer

It needs source-build attention due to sourcelink changes.

Apr 23 '24 14:04 mmitche

I remember what this is about. This got fixed in main with https://github.com/dotnet/arcade/commit/cd27fcf3c2b5c238acd3e8d1e85bb6ef6c205686. We worked around this in main by setting RepositoryUrl: https://github.com/dotnet/arcade/commit/89008f339a79931cc49c739e9dbc1a27c608b379

That workaround isn't great though as I would need to be set in all consuming repos.

Apr 23 '24 14:04 ViktorHofer

This still needs the source-build workaround that I mentioned above at least here but probably also in various consuming repositories.

May 15 '24 13:05 ViktorHofer