dotnet
Need support for custom build triggers that can set properties
@weshaggard commented on Wed Nov 29 2017
There have recently been a need for having build triggers that can setup custom properties. See https://github.com/dotnet/corefx/issues/25382 as an example. We have talked about doing that for signing as well to have at least one signed build a week from master.
Currently the built in VSTS triggers don't allow you to set properties but it seems like it would be easy enough to add this to the maestro infrastructure we already have.
@dagood commented on Wed Nov 29 2017
Agreed it makes sense to use maestro for this, ties in with https://github.com/dotnet/core-eng/issues/936.
@mmitche commented on Tue Feb 20 2018
I have asked VSTS to ensure this is in their config as code solution too.
@weshaggard commented on Tue Feb 20 2018
@mmitche I assume you didn't intend to close. If you did then please point me at the changes that enabled.
@mmitche commented on Tue Feb 20 2018
@weshaggard Not yet. I requested that this be part of VSTS's config as code trigger spec. Different triggers will allow for different parameter sets.
@mmitche commented on Tue Feb 20 2018
So i would not like to do throwaway work here.
@weshaggard commented on Tue Feb 20 2018
It would be great if VSTS can support this but depending on their timeline we might consider still adding this feature to Maestro as it seems like a useful scenario for our Maestro even if we don't use it for this particular purpose.
@mmitche commented on Tue Feb 20 2018
Timeline for them is like....a month from now IIRC.
@mmitche commented on Mon Apr 30 2018
I think we should work with VSTS on this, rather than build support into other tools.
@weshaggard commented on Mon Apr 30 2018
@mmitche I'm fine with that as an approach but I'd still like to keep this open until we have a solution for it.
This is (hopefully) related to the current VSTS effort which is underway to support custom properties as part of a PR. We need to follow up with VSTS to make sure this is generic enough.
As far as I'm aware this scenario isn't covered by anything yet. For corefx we only run our release builds nightly but would like to setup a trigger to run a debug build once a week but to do that we need some way to set a trigger with a custom property getting set. As far as I can tell VSTS doesn't offer that option.
Ongoing discussion - https://github.com/Microsoft/azure-pipelines-agent/pull/1383/files
Hey @chcosta, https://github.com/Microsoft/azure-pipelines-agent/pull/1383 is still open and the last comment was on 10/10/18. Is this still on the works or we can close this issue?