arcade icon indicating copy to clipboard operation
arcade copied to clipboard

Remove AzureStorageTargetFeedPAT

Open epananth opened this issue 2 years ago • 4 comments

To double check:

Issue -> https://github.com/dotnet/arcade/issues/13963

  • [ ] The right tests are in and and the right validation has happened. Guidance: https://github.com/dotnet/arcade/tree/main/Documentation/Validation

epananth avatar Nov 07 '23 22:11 epananth

There's a build failure:

src/Microsoft.DotNet.Build.Tasks.Feed/src/model/SetupTargetFeedConfigV3.cs(61,15): error CS7036: There is no argument given that corresponds to the required formal parameter 'azureDevOpsFeedsKey' of 'SetupTargetFeedConfigBase.SetupTargetFeedConfigBase(bool, bool, string, string, string, bool, string, string, string, string, string, string, string, string, string)'

akoeplinger avatar Nov 08 '23 15:11 akoeplinger

@missymessa The 6.0 SDK doesn't have a new enough compiler for scoped, I think.

mmitche avatar Nov 15 '23 18:11 mmitche

@missymessa The 6.0 SDK doesn't have a new enough compiler for scoped, I think.

Odd, it compiles for me locally. I think we need to rethink our approach here. There's a bit of a divergence between all versions involved, even around the tests, that I'm concerned about ensuring parity between all versions as we refactor out this value.

missymessa avatar Nov 15 '23 18:11 missymessa

The swagger generator and most of the publishing code is actually not used outside of main. We probably could delete a lot of it.

mmitche avatar Nov 15 '23 18:11 mmitche