arcade icon indicating copy to clipboard operation
arcade copied to clipboard

`Publish.proj` does not respect SymbolPublishingExclusionsFile

Open dibarbet opened this issue 1 year ago • 1 comments

The documentation lists this method for configuring excluded files in symbol packages - https://github.com/dotnet/arcade/blob/main/Documentation/CorePackages/Publishing.md#can-we-exclude-symbols-from-publishing-to-symbols-server which allows a file to be added to specify paths to exclude from the symbol publishing package. This does appear to be respected in PublishToSymbolServer.proj,

Bug

However this file is not respected in Publish.proj - no files are excluded from the packages.

This means I am unable to exclude files from symbol packages whenever Publish.proj gets invoked. This was found in https://github.com/dotnet/roslyn/pull/70162 and build https://dev.azure.com/dnceng-public/public/_build/results?buildId=429092&view=logs&j=0f289b55-e51e-537b-a78d-659668d39b05&t=65ecf3f3-6240-545e-af3c-b1c21351fb50

dibarbet avatar Oct 06 '23 18:10 dibarbet

@epananth are you still working on this?

missymessa avatar Nov 30 '23 21:11 missymessa

@epananth What's the status with this? It looks like it's stalled. Are you still working on it?

garath avatar Mar 25 '24 18:03 garath

Hi, this becomes a blocker for https://github.com/dotnet/roslyn-tools/pull/1396 Is there any update?

Cosifne avatar Mar 26 '24 18:03 Cosifne

This documentation pertains to publishing with V3, specifically utilizing the publishToSymbolServer.proj. It has never been functional with publish.proj.

That being said, I am trying to re-evaluate if there is a work around you could use.

epananth avatar Mar 26 '24 19:03 epananth

try passing /p:DotnetPublishUsingPipelines=true in your build command.

epananth avatar Mar 26 '24 20:03 epananth

https://teams.microsoft.com/l/message/19:[email protected]/1711649646692?tenantId=72f988bf-86f1-41af-91ab-2d7cd011db47&groupId=4d73664c-9f2f-450d-82a5-c2f02756606d&parentMessageId=1711649646692&teamName=.NET%20Core%20Eng%20Services%20Partners&channelName=Arcade&createdTime=1711649646692

we were able to find a work around for this one. Closing this issue

epananth avatar Apr 02 '24 21:04 epananth