arcade icon indicating copy to clipboard operation
arcade copied to clipboard

Remove all hard-coded c:\ paths from Helix machines artifacts

Open MattGal opened this issue 3 years ago • 1 comments

DDFUN needs to be able to run Helix agents off the D:\ drive; this is often broken by hard-coded c:\ paths inside the scripts, which puts some files onto the UIP imaging drive often which can be small.

@JpratherMS FYI

MattGal avatar Sep 12 '22 18:09 MattGal

https://dnceng.visualstudio.com/internal/_git/dotnet-helix-machines/pullrequest/26042

MattGal avatar Sep 20 '22 22:09 MattGal

This is rolled out, closing. @JpratherMS FYI; let me know if you see any issues with machine setup after 9/28.

MattGal avatar Sep 29 '22 16:09 MattGal

@parose1 showed me a problem with this today, reactivating so I can fix two more locations with the problem.

MattGal avatar Oct 19 '22 21:10 MattGal

https://dnceng.visualstudio.com/internal/_build/results?buildId=2025314&view=results should fix the issue and removes the last two c:\’s in the entire repository. Once merged and in staging, I'll work with @parose1 to see if this sorts the problem.

MattGal avatar Oct 19 '22 23:10 MattGal

@parose1 the pull request above is merged and deployed to the staging environment. Can we try imaging one of those UIP windows machines you were hitting this issue on before via the staging environment?

MattGal avatar Oct 21 '22 14:10 MattGal

@parose1 found one more place we had this, addressed in https://dnceng.visualstudio.com/internal/_git/dotnet-helix-machines/pullrequest/27051. I also had to change artifacts around to be able to put the helix disk on D:\ for this queue.

MattGal avatar Oct 26 '22 20:10 MattGal

@parose1 is OOF until tomorrow so I'll check back with him then about whether this finally solves the problem.

MattGal avatar Oct 31 '22 16:10 MattGal

@MattGal I have tested the new changes in staging, and everything is working correctly now. The machines get added to the queue and start heart beating automatically. Thank you!

parose1 avatar Nov 01 '22 15:11 parose1

This is rolled out, closing.

MattGal avatar Nov 02 '22 23:11 MattGal