arcade icon indicating copy to clipboard operation
arcade copied to clipboard

SBOM for VS insertions manifest tool error

Open epananth opened this issue 3 years ago • 3 comments

  • [x] This issue is blocking
  • [ ] This issue is causing unreasonable pain
Repo name Do we need to do anything here? Infra error / Repo Error / Sbom manifest tool error
vs-code-debugger (https://github.com/microsoft/dropvalidator/issues/455) SBOM manifest tool error
dotnet-winforms-designer (https://github.com/microsoft/dropvalidator/issues/455) SBOM manifest tool error
MS.VS.Debugger.BrokeredServices Figuring out arcade update Repo error
dotnet-msbuild (https://github.com/microsoft/dropvalidator/issues/455) SBOM manifest tool error
razor-tooling (https://github.com/microsoft/dropvalidator/issues/455) Sbom manifest tool error
Fsharp (https://github.com/microsoft/dropvalidator/issues/455) SBOM tool error

epananth avatar Jul 20 '22 23:07 epananth

We have 3 issues open for microsoft/dropvalidator repo

  1. https://github.com/microsoft/dropvalidator/issues/455 - This is blocking the following repos Razor tooling, winforms-designer, f sharp to generate sbom for VS insertion

  2. https://github.com/microsoft/dropvalidator/issues/466 - This is blocking Razor tooling alpine leg sbom generation for dontet

  3. https://github.com/microsoft/dropvalidator/issues/454 - This is blocking msbuild to generate sbom for VS insertion.

epananth avatar Jul 20 '22 23:07 epananth

We need the manifest tool folks to fix the issues. After the issue is fixed we need to update the GenerateSbom flag to true in the above mentioned repos (in the pipeline yaml)

epananth avatar Jul 20 '22 23:07 epananth

Continuing to work with the microsoft/dropvalidator team to address our open issues.

ilyas1974 avatar Aug 12 '22 19:08 ilyas1974

Alpine leg error fix is merged and I did see some positive runs in runtime : https://dev.azure.com/dnceng/internal/_build/results?buildId=1960979&view=results But we see some warning : https://dev.azure.com/dnceng/internal/_build/results?buildId=1960979&view=logs&j=79152c53-978f-5956-309f-f18ecaacb149&t=d038bec2-71ea-5576-6a31-c1121da57f0d

epananth avatar Aug 23 '22 16:08 epananth

SBOM team has not completed the test for the alpine leg, so they rolled back

epananth avatar Aug 23 '22 18:08 epananth

Updated test runs on the issue. MAGICALLY the builds for the issue microsoft/dropvalidator#455 starting to work.

PS : I have NOT made any changes to this piece of code. IDK if the sbom team pushed any change that fixed this issue

epananth avatar Aug 23 '22 21:08 epananth

All the repos except fsharp worked, trying to see why that one is spl.

epananth avatar Aug 24 '22 23:08 epananth

I tried to get a repro in fsharp, I got an error in signing ( after 4 hours of waiting) I have requeued the build. @MattGal said he will help me look at the error but I'm not getting a proper repro. I will try to get it EOD or next week.

epananth avatar Aug 26 '22 22:08 epananth

@epananth I have two questions for this:

  • What is the current status of this?
  • Should this be tracked in FR?

Chrisboh avatar Sep 13 '22 16:09 Chrisboh

@epananth any updates here?

MattGal avatar Sep 30 '22 16:09 MattGal

Apologize for the delay, I was oof for some time, I couldn't get to this earlier. I will update this by EOD

epananth avatar Oct 03 '22 18:10 epananth

vs-code-coverage repo is working, I am looking at F sharp and machine-learning repo now

epananth avatar Oct 03 '22 19:10 epananth

I did some tests in machine learning repo, looks like they have some upstream package error they are fixing.

epananth avatar Oct 03 '22 23:10 epananth

I was not able to run the test for f sharp, I have some permission issue.. I pinged some folks from the team to get more info

epananth avatar Oct 04 '22 04:10 epananth

unblocked dotnet-machinelearning repo

epananth avatar Oct 07 '22 00:10 epananth

Fsharp is the last repo working on that

epananth avatar Oct 07 '22 00:10 epananth

VSDebug-Core I had the successful build already, helping the owner with the PR today.

epananth avatar Oct 10 '22 18:10 epananth

all the repos are onboarded except Fsharp. Fsharp has customized build a lot. The way they generate vsix files are totally different from all the repos we have dealt with so far. I have asked Kevin Ransome to take a look at the vsix file generation and move some things out of the folder we actually care for sbom generation. Once that is done, I will retry sbom generation.

epananth avatar Oct 12 '22 18:10 epananth

Fsharp was fixed this week. This is complete! PR- https://github.com/dotnet/fsharp/pull/14029

Thank you for your patience :)

epananth avatar Oct 27 '22 20:10 epananth