arcade-services icon indicating copy to clipboard operation
arcade-services copied to clipboard

Add a forward flow merge policy check

Open premun opened this issue 10 months ago • 1 comments

Context

For forward flows, we need to verify that people haven't messed up the source-manifest.json record in the VMR.

Goal

  • Create a new forward flow merge policy which will run on source-enabled subscriptions into the VMR
    • The policy will check if the BAR ID and VMR SHA in the source-manifest.json file in the PR head branch matches the currently flown build
    • It needs to refresh for every commit
    • In case of failure, it needs to explain why, give people instructions / contact for our team
    • The policy will probably do more in the future
  • Include the policy in the Standard merge policy

Notes

Should be done together with #4525 (not sure which first)

premun avatar Mar 04 '25 13:03 premun

@premun I assume this should work for batched PRs as well - when the policy merge check triggers, it should gather all the flowed builds contained in the PR and check the corresponding entries in source-manifest.json

adamzip avatar Mar 17 '25 13:03 adamzip