arcade-services icon indicating copy to clipboard operation
arcade-services copied to clipboard

Refactor Darc to properly use DI

Open dkurepa opened this issue 1 year ago • 1 comments

Darc dependency injection is currently messy, and we keep breaking it while developing because we're currently not able to have proper test coverage for the DI. We should refactor it, and then add DependencyRegistrationTests like we do for all other projects

dkurepa avatar Jul 22 '24 11:07 dkurepa

@dkurepa somehow the DI test is hanging in CI but goes green locally. I didn't have time to fix this but I finished your PR and merged it without it.

premun avatar Jul 25 '24 10:07 premun

I'll close this issue now. I created a followup and included the DI registration test in it https://github.com/dotnet/arcade-services/issues/3785

dkurepa avatar Aug 05 '24 16:08 dkurepa