Consider skipped checks as meeting Maestro policy

[mmitche]

Release Note Category

• [x] Feature changes/additions
• [ ] Bug fixes
• [ ] Internal Infrastructure Improvements

Release Note Description

Consider skipped checks as meeting Maestro policy

[premun]

@mmitche see my comment in Teams about ignored checks and then merge this if you still feel like we should do this

[oleksandr-didyk]

Rolled-out by https://github.com/dotnet/arcade-services/pull/3972

[mmitche]

This doesn't appear to have worked as expected:

https://github.com/dotnet/sdk/pull/43972

[mmitche]

It may be that the check is actually neutral and not skipped

[premun]

I guess we need to check the GitHub API response to see what is the actual value it returns

[premun]

The GraphQL gives me this:

"checkRuns": {
  "nodes": [
    {
      "name": "sdk-unified-build",
      "status": "COMPLETED",
      "conclusion": "NEUTRAL"
    },
}

[premun]

@mmitche are we worried that Neutral is also the state before we queue the check? I remember some worries like that so that the service does not merge stuff right away (though we do the 5 minute delay I believe after opening a PR now)

[premun]

https://github.com/dotnet/arcade-services/pull/4026

[akoeplinger]

Last time we did try to change the neutral state: https://github.com/dotnet/arcade-services/pull/2997

[marcpopMSFT]

Any more news here? Still affecting SDK PR checks.

[nagilson]

Any updates here? Thanks for investigating.