arcade-services icon indicating copy to clipboard operation
arcade-services copied to clipboard

[Arcade-Services] Check for usage of unsupported linq methods in EF queries

Open dotnet-bot opened this issue 2 years ago • 0 comments

Migrated from https://github.com/dotnet/core-eng/issues/10078

@riarenas wrote:

https://docs.microsoft.com/en-us/dotnet/framework/data/adonet/ef/language-reference/supported-and-unsupported-linq-methods-linq-to-entities contains a list of supported and unsupported linq methods that we can use.

@ChadNedzlek made an effort to remove all usage of these operators, but we missed some places.

https://github.com/dotnet/core-eng/issues/10072 made evident that we missed some LastOrDefaults in the BuildsController of older API versions which are still in use by the 3.x publishing infrastructure:

https://github.com/dotnet/arcade-services/blob/c54e38e5279d582ce71812733f9894c487de46d4/src/Maestro/Maestro.Web/Api/v2019_01_16/Controllers/BuildsController.cs#L250-L262

dotnet-bot avatar Apr 07 '22 21:04 dotnet-bot