arcade-services icon indicating copy to clipboard operation
arcade-services copied to clipboard

[darc/maestro++] Make merge policies source clear in `darc` output

Open mmitche opened this issue 6 years ago • 0 comments

@dougbu commented on Wed Jul 03 2019

darc get-subscriptions confusingly shows non-empty policies for batchable subscriptions. If this command is going to display repository policies, it should be clear the policies aren't actually part of the subscription definition. An alternative would be to show no policies or (perhaps best) to display just an indication that repo policies exist for the target branch.

For example,

darc get-subscriptions --target-repo https://github.com/aspnet/AspNetCore$ --regex --target-branch master --channel '.NET Tools - Latest'
https://github.com/dotnet/arcade (.NET Tools - Latest) ==> 'https://github.com/aspnet/AspNetCore' ('master')
  - Id: 4409590c-0c9e-4f51-7dbf-08d6ba16a224
  - Update Frequency: EveryWeek
  - Enabled: True
  - Batchable: True
  - Merge Policies:
    AllChecksSuccessful
      ignoreChecks =
                       [
                         "AspNetCore-helix-test",
                         "license/cla"
                       ]
    NoRequestedChanges
darc get-repository-policies --repo aspnet/AspNetCore --branch master
https://github.com/aspnet/AspNetCore @ master
- Merge Policies:
  AllChecksSuccessful
    ignoreChecks =
                   [
                     "AspNetCore-helix-test",
                     "license/cla"
                   ]
  NoRequestedChanges
https://github.com/aspnet/AspNetCore-Tooling @ master
- Merge Policies:
  Standard

@garath commented on Thu Jul 11 2019

@mmitche @jcagme Where's the best place to track this?


@mmitche commented on Thu Jul 11 2019

I this repo is fine. Need to create a p8 or GA epic for dependency flow to put this in.

mmitche avatar Aug 01 '19 17:08 mmitche