TorchSharp icon indicating copy to clipboard operation
TorchSharp copied to clipboard

TorchVision keep the folder structures consistent between pytorch and Torchsharp?

Open GeorgeS2019 opened this issue 2 years ago • 7 comments

@MovGP0

Should we keep the folder structures consistent between pytorch and Torchsharp?

pytoch vision

TorchSharp vison

GeorgeS2019 avatar Feb 17 '23 19:02 GeorgeS2019

@MovGP0

I was looking into the code coverage of Torchsharp for Microsoft Pytorch learning project. It seems a great extend is using TorchVision

PyTorch Fundamentals

https://github.com/MicrosoftDocs/pytorchfundamentals/tree/main/intro-to-pytorch

GeorgeS2019 avatar Feb 17 '23 20:02 GeorgeS2019

I don't think that keeping the folder structure the same is of importance.

NiklasGustafsson avatar Feb 17 '23 22:02 NiklasGustafsson

With the right structure, it is easier to see what have and have not implemented :-)

GeorgeS2019 avatar Feb 17 '23 22:02 GeorgeS2019

my opinion is to align the folder structures, such that it becomes easier to track what is implemented and what is still missing.

MovGP0 avatar Feb 19 '23 10:02 MovGP0

that beeing said, there can be edge cases where it is justified to deviate from the source. But it should be because of technical reasons, like differences in the programming language.

MovGP0 avatar Feb 19 '23 10:02 MovGP0

@MovGP0 Thx for your feedback

The dotnet .Interactive or PolyGlot notebook team is currently seeking people to test new features where python could potentially share variables with c#.

I could imagine with the right TorchSharp community support, the data exchange between PyTorch and TorchSharp within the PolyGlot notebook could be simpler and INTUITIVE than what is currently needing the users here to do.

When that happens, more c# users will adopt TorchSharp, more users will contribute to addressing the missing implementation in TorchSharp.

==> More users will need the "Right folder structures" to coordinate their effort to KEEP TorchSharp UP-To-Date with the latest PyTorch development.

GeorgeS2019 avatar Feb 19 '23 11:02 GeorgeS2019

I will invite the dotnet PM here (if she is interested) to invite more users HERE to join the testing of the new PolyGlot WIP features.

GeorgeS2019 avatar Feb 19 '23 11:02 GeorgeS2019