Silk.NET icon indicating copy to clipboard operation
Silk.NET copied to clipboard

3.0's SilkTouch affected by a ClangSharp upstream bug whereby test code is in XML

Open Perksey opened this issue 4 years ago • 6 comments

Example file: out.xml.txt

This needs to be fixed upstream in the ClangSharp repo and the version updated in our projects once a new update is released encompassing these changes.

The likely culprit is the OutputFactoryBuilder, but don't quote me on that.

Related #557

Perksey avatar Aug 10 '21 18:08 Perksey

cc @tannergooding

Perksey avatar Aug 10 '21 19:08 Perksey

So basically you want XML product code and C# tests?

tannergooding avatar Aug 10 '21 19:08 tannergooding

This particular issue is because we're getting C# test code added to the XML output file (only in single-file mode mind) even though the OutputMode is Xml and, to my knowledge, we're not enabling test output (which is presumably why the test implementations are empty)

#557 is for discussing designing a way to get tests exposed in XML. But right now there should be no tests exposed in XML whatsoever, the bug is there are.

Perksey avatar Aug 10 '21 19:08 Perksey

@HurricanKai for visibility

Perksey avatar Jan 29 '22 16:01 Perksey

For future reference, this is what the issue looks like in the file: image

HurricanKai avatar Apr 18 '22 15:04 HurricanKai

This should be pretty straightforward to resolve in ClangSharp. We should really just have "single file mode" output separate files for "source" vs "tests".

If this is a priority, let me know and I can take a look at it sooner

tannergooding avatar Apr 18 '22 16:04 tannergooding