Silk.NET icon indicating copy to clipboard operation
Silk.NET copied to clipboard

Proposal - 3.0 Additional types for Silk.NET.Maths

Open dfkeenan opened this issue 2 years ago • 3 comments

Summary of the PR

A proposal for additional types to the Silk.NET.Maths library for 3.0.

Related issues, Discord discussions, or proposals

As discussed in discord with the SilkX team.

dfkeenan avatar Nov 19 '23 05:11 dfkeenan

@dotnet-policy-service agree

dfkeenan avatar Nov 19 '23 06:11 dfkeenan

Provisionally adding this to the next working group meeting agenda (date not yet set)

Perksey avatar Feb 21 '24 03:02 Perksey

Angle (and other such types) shouldn't have a public constructor, that completely voids the point of having the type as it's not clear what underlying unit is being passed in without reading the code. That's why we have FromDegrees and FromRadians. Angle.Sin(new Angle(1.0)) is no more clear than Math.Sin(1.0), but Angle.Sin(Angle.FromRadians(1.0)) is.

uwx avatar Apr 24 '24 04:04 uwx