Silk.NET
Silk.NET copied to clipboard
dotnet
Start of windowing implementation
Implements "Stub" windowing API, the framework is there, but the meat and potatoes are not currently implemented
Summary of the PR
Essentially adds the interfaces as defined in the Windowing(3.0) proposal
I can answer any outstanding proposal wording questions in a bit, really annoyed this didn’t come up in #539 though.
Yeah me too - We've been less then thorough with that review. I guess I was just so into the idea cause we came up with it only few days before, and didn't see any problems with it.
Can you propose a change to the proposal itself? It's unfair to expect an external contributor to answer to this.
I don't really expect any contributor to answer this, I just figured tracking it here associated directly with the code seems easier. If you want I'll delete the proposal and re-submit it, and attach the comments there.
I was more suggesting propose changes to the proposal in response to your comments yourself, probably the most productive :) again I can help respond in a bit.
Ah wups, yeah will do that once I'm done with my current work item. Just wanted to get my review out there, and will resolve any outstanding things once I get to windowing.
Ah wups, yeah will do that once I'm done with my current work item. Just wanted to get my review out there, and will resolve any outstanding things once I get to windowing.
Does this mean I other than some the slight changes I am stuck?
Not necessarily, your free to put in any work you want to, but no one expects you to do any of the proposal work. Ill look at perkseys proposals in the morning and then also submit proposal changes, but heading to bed now.
This has an outstanding action on @HurricanKai to change the proposals, but there is little work being done here at this time. Should we merge just so we have something in the repo as this does technically implement the approved API as it currently stands?
I think this activity has proven that we're not necessarily ready to work on this right now.
Opinions for closing for now?
Doesn't seem like this will be implemented anytime soon, and there's lots of conflicts.