MQTTnet icon indicating copy to clipboard operation
MQTTnet copied to clipboard

Published 20 hours ago • verified publisher icon dotnet

Support for hosting extensions

Open YAJeff opened this issue 2 years ago • 10 comments

With this change, the MQTTnet server can be hosted using Microsoft.Extensions.Hosting library, rather than full ASP.net core SDK.

YAJeff avatar Jan 21 '23 02:01 YAJeff

@YAJeff Please agree to the Contributor License. Then I will merge this PR.

chkr1011 avatar Apr 23 '23 15:04 chkr1011

@dotnet-policy-service agree company="CARIAD Inc"

kallayj avatar Oct 26 '23 19:10 kallayj

@chkr1011 I've merged the latest from main into @YAJeff's fork and agreed to the CLA on behalf of the company we both work for.

kallayj avatar Oct 26 '23 23:10 kallayj

@kallayj This does not seem to work. The agreement is still in "Contributor License Agreement is not agreed yet." state. I am afraid you have to create a new PR on your own (or please @YAJeff) to accept it.

chkr1011 avatar Nov 04 '23 11:11 chkr1011

@dotnet-policy-service agree company="CARIAD Inc"

YAJeff avatar Nov 06 '23 22:11 YAJeff

@chkr1011 the CLA check has passed, can this move forward?

kallayj avatar Nov 08 '23 22:11 kallayj

@kallayj I applied the code style and moved the tests a little around to get the code compiling.

There are still some warnings left and some new properties are not even used. Please let me know when the code is finished so that I can review it.

chkr1011 avatar Nov 18 '23 09:11 chkr1011

@chkr1011 I addressed the nullable reference type warnings. Where are you seeing unused properties?

kallayj avatar Nov 20 '23 19:11 kallayj

Please see "MqttServerHostingOptions.WebSocketRoute". It is set but never read. Same for "WebSocketAuthenticationCallback".

chkr1011 avatar Nov 25 '23 15:11 chkr1011

@chkr1011 I removed those properties.

kallayj avatar Nov 29 '23 19:11 kallayj