LLVMSharp icon indicating copy to clipboard operation
LLVMSharp copied to clipboard

Migrate LibLLVM to dotnet core to suppress warnings

Open ice1000 opened this issue 7 years ago • 11 comments

When I run dotnet msbuild locally, I get warning:

warning NU1701: Package 'LibLLVM 5.0.1' was restored using '.NETFramework,Version=v4.6.1' instead
of the project target framework '.NETCoreApp,Version=v2.0'. This package may not be fully compatible
with your project.

Please upgrade LibLLVM to dotnet core 2.0.

ice1000 avatar Dec 11 '17 08:12 ice1000

Or dotnet core 2.0.3.

ice1000 avatar Dec 14 '17 04:12 ice1000

So far @mjsabby has been building the LibLLVM DLL, so I've assigned this to him. I myself haven't been able to build LibLLVM successfully for some reason, but I'll give it a try again.

TChatzigiannakis avatar Dec 22 '17 09:12 TChatzigiannakis

Thanks @TChatzigiannakis :+1:

ice1000 avatar Dec 22 '17 09:12 ice1000

:sob: Why, why this issue is left abandoned

ice1000 avatar Jan 20 '18 09:01 ice1000

@ice1000 I think this is fixed, have you tried it?

mjsabby avatar Mar 10 '18 23:03 mjsabby

Haven't yet, I'll test this within few days since I'm busy with work. I'll close this issue after trying upgrading my LLVM#.

ice1000 avatar Mar 11 '18 07:03 ice1000

@ice1000 is this issue resolved?

metanoic avatar Jul 11 '18 04:07 metanoic

@metanoic ask the repo owner, I haven't touched this since then

ice1000 avatar Jul 11 '18 05:07 ice1000

@ice1000 alrighty.. just figured since your last activity was "I'll test it" and it being your ticket and all that you'd have either closed it or got things sorted.

metanoic avatar Jul 11 '18 09:07 metanoic

Installing LibLLVM 5.0.1.
Installing LLVMSharp 5.0.0.
warning NU1701: Package 'LibLLVM 5.0.1' was restored using '.NETFramework,Version=v4.6.1' instead of the project target framework '.NETStandard,Version=v2.0'. This package may not be fully compatible with your project.

andyjansson avatar Oct 28 '18 01:10 andyjansson

I'm going to go ahead move this project to .NETStandard 2.0 so that more people can benefit. Although it will mean that people using this project in projects < .NET 4.7.1 will now have more assemblies output in their program, but nuget will take care of that.

mjsabby avatar Nov 10 '18 05:11 mjsabby