EntityFramework.Docs icon indicating copy to clipboard operation
EntityFramework.Docs copied to clipboard

3203-add multiple parameter examples for FromSqlRaw

Open Rezakazemi890 opened this issue 1 year ago • 3 comments

  • [x] I've read the guidelines for contributing and seen the walkthrough
  • [x] I've posted a comment on an issue with a detailed description of how I am planning to contribute and got approval from a member of the team
  • [x] The code builds and tests pass locally (also verified by our automated build checks)
  • [x] Commit messages follow this format:
        Summary of the changes
        - add multiple parameter examples for FromSqlRaw.
        
        Fixes #3203
  • [x] Tests for the changes have been added (for bug fixes / features)
  • [x] Code follows the same patterns and style as existing code in this repo

Fixes #3203

Rezakazemi890 avatar Feb 16 '24 22:02 Rezakazemi890

@Rezakazemi890 The code no longer aligns with the text that surrounds it.

Note for team: I'm not sure what value there is in showing multiple parameters.

ajcvickers avatar Feb 19 '24 13:02 ajcvickers

@Rezakazemi890 The code no longer aligns with the text that surrounds it.

Note for team: I'm not sure what value there is in showing multiple parameters.

@ajcvickers Do you mean this part of the text? https://learn.microsoft.com/en-us/ef/core/querying/sql-queries#passing-parameters:~:text=In%20the%20above,rejecting%20such%20inputs.

And that it should be changed according to the code? If you approve, I will change that part of the text as well.

Rezakazemi890 avatar Feb 19 '24 19:02 Rezakazemi890

I'm not sure what value there is in showing multiple parameters

@ajcvickers I agree - I don't see what value this adds... Better keep the samples simple and minimal.

roji avatar Feb 20 '24 09:02 roji

Closing based on discussion above.

ajcvickers avatar Mar 26 '24 08:03 ajcvickers