Docker.DotNet icon indicating copy to clipboard operation
Docker.DotNet copied to clipboard

Can't use Docker.DotNet.X509 with Docker.DotNet 3.125.4

Open msvprogs opened this issue 5 years ago • 4 comments

What version of Docker.DotNet?:

3.125.4

Steps to reproduce the issue:

  1. Install Docker.DotNet 3.125.4 and last version of Docker.DotNet.X509 (3.125.2) in the same project
  2. Create docker client with certificate credentials
var credentials = new CertificateCredentials(clientCertificate);
var configuration = new DockerClientConfiguration(uri, credentials, m_Options.Timeout.GetValueOrDefault());

return configuration.CreateClient();
  1. This code with fail with exception
System.IO.FileNotFoundException: Could not load file or assembly 'Docker.DotNet, Version=3.125.2.0, Culture=neutral, PublicKeyToken=null'. The system cannot find the file specified.

File name: 'Docker.DotNet, Version=3.125.2.0, Culture=neutral, PublicKeyToken=null'

Additional information: Probably you should bump up the version of Docker.DotNet.X509 package and update its dependency on Docker.DotNet.

msvprogs avatar Aug 29 '20 15:08 msvprogs

Me too. only reinstall Docker.DotNet to version 3.125.2.0.

treenewlyn avatar Sep 08 '20 13:09 treenewlyn

This is also the case with the Basic Authentication.

abarringtonACR avatar Oct 06 '20 17:10 abarringtonACR

I encounter the same issue using Docker.DotNet, v. 3.125.5 and Docker.DotNet.X509, v. 3.125.2. Is it planned releasing a new version of the package?

SchlenkR avatar Jan 17 '22 14:01 SchlenkR

It seems like according to https://github.com/dotnet/docs/issues/7146, dotnet nuget push here - https://github.com/dotnet/Docker.DotNet/blob/master/.github/workflows/publish.yml#L35 - only pushes the first package it finds, that being Docker.DotNet. That causes the other packages to be out of date, and it means users of X509 or BasicAuth can't update this library above 3.125.2

I can't really confirm it since I can't see the CI logs, but it seems like changing

dotnet nuget push ./packages/Docker.DotNet.*.nupkg -k ${{ secrets.NUGET_KEY }} -s https://api.nuget.org/v3/index.json

to

dotnet nuget push './packages/Docker.DotNet.*.nupkg' -k ${{ secrets.NUGET_KEY }} -s https://api.nuget.org/v3/index.json

in publish.yml may fix it, and the next release with such a change to Github Actions should update all three packages.

@galvesribeiro any plans to fix it in the next release?

mdarocha avatar Jan 24 '22 19:01 mdarocha